Skip to content

feat: expose inline material content #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2023
Merged

feat: expose inline material content #343

merged 1 commit into from
Sep 15, 2023

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Sep 14, 2023 •
edited
Loading

  • exposes inline material content in the API. This will allow us clients to "simulate" downloads
  • Decouples the API material type filename/value properties, similarly to what we already did in the normalizedMaterial/integrations. This allow us to be more precise in what to show.
  • The CLI now shows the filename if needed properly in its own option.

refs #275

@migmartri
feat: expose inline material content
27a8e2f 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested a review from danlishka September 14, 2023 12:19
danlishka
danlishka approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri migmartri merged commit 2ff72da into chainloop-dev:main Sep 15, 2023
@migmartri migmartri deleted the add-inline-content branch September 15, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlishka danlishka danlishka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@migmartri @danlishka