Skip to content

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Oct 12, 2023

Adds support for Azure KeyVault for credentials handling.

image

image

Refs #376

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri marked this pull request as ready for review October 13, 2023 15:31
}

// Delete the associated repository
// Currently there is only one repository per organization
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bug we had that affected user offboarding. We only deleted the main cas backend instead all of them.

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Copy link
Collaborator

@gr0 gr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants