Skip to content

feat(deployment): Azure KeyVault support #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2023
Merged

feat(deployment): Azure KeyVault support #389

merged 4 commits into from
Oct 16, 2023

Conversation

migmartri
Copy link
Member

@migmartri migmartri commented Oct 14, 2023 •
edited
Loading

Update Helm Chart to support configuring Azure KeyVault, depends on #388

This is the result of adding the following configuration to the values.yaml file

secretsBackend:
  backend: azureKeyVault
  azureKeyVault:
    tenantID: [REDACTED]
    clientID: [REDACTED]
    clientSecret: [REDACTED]
    vaultURI: https://[REDACTED].vault.azure.net/

image

Closes #357

@migmartri
feat(deployment): Azure KeyVault support
dbed165 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
chore: change camelcase
09c3d68 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
chore: change camelcase
ca55c61 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
chore: update readme
bc8cfd5 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested review from gr0 and danlishka October 14, 2023 16:42
danlishka
danlishka approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@danlishka danlishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migmartri migmartri merged commit a344ad4 into chainloop-dev:main Oct 16, 2023
@migmartri migmartri deleted the azure-key-vault-chart branch October 16, 2023 14:01
@p-linnane p-linnane mentioned this pull request Oct 17, 2023
Merged
@chenrui333 chenrui333 mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlishka danlishka danlishka approved these changes

@gr0 gr0 Awaiting requested review from gr0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Blob Storage support in CAS
2 participants
@migmartri @danlishka