Skip to content

Conversation

migmartri
Copy link
Member

This patch enables an additional Prometheus histogram with the total time per request.

For example, upload times

grpc_server_handling_seconds_sum{grpc_method="Read",grpc_service="google.bytestream.ByteStream",grpc_type="server_stream"} 24.683958404000002
grpc_server_handling_seconds_count{grpc_method="Read",grpc_service="google.bytestream.ByteStream",grpc_type="server_stream"} 2

or client stream uploads

grpc_server_handling_seconds_sum{grpc_method="Write",grpc_service="google.bytestream.ByteStream",grpc_type="client_stream"} 10.418738306000002
grpc_server_handling_seconds_count{grpc_method="Write",grpc_service="google.bytestream.ByteStream",grpc_type="client_stream"} 4

This patch also tweaks the histogram buckets on the CAS case since those requests have different time baselines (uploads, download streaming)

Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested review from danlishka and zaibon October 19, 2023 20:15
@migmartri migmartri merged commit 7e1a3c4 into chainloop-dev:main Oct 21, 2023
@migmartri migmartri deleted the add-metrics branch October 21, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants