Skip to content

chore(api): enable request time histogram #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2023
Merged

chore(api): enable request time histogram #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/artifact-cas/internal/server/grpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import (
jwtMiddleware "github.com/go-kratos/kratos/v2/middleware/auth/jwt"
"github.com/go-kratos/kratos/v2/middleware/selector"
jwt "github.com/golang-jwt/jwt/v4"
"github.com/prometheus/client_golang/prometheus"
"google.golang.org/genproto/googleapis/bytestream"

"github.com/go-kratos/kratos/v2/log"
Expand Down Expand Up @@ -92,6 +93,10 @@ func NewGRPCServer(c *conf.Server, authConf *conf.Auth, byteService *service.Byt
grpc.UnaryInterceptor(grpc_prometheus.UnaryServerInterceptor),
}

// Opt-in histogram metrics for the interceptor
// Since we track uploads / downloads we'll increase the buckets
grpc_prometheus.EnableHandlingTimeHistogram(grpc_prometheus.WithHistogramBuckets(prometheus.ExponentialBucketsRange(0.5, 60, 8)))

if c.Grpc.Network != "" {
opts = append(opts, grpc.Network(c.Grpc.Network))
}
Expand Down
3 changes: 3 additions & 0 deletions app/controlplane/internal/server/grpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ type Opts struct {

// NewGRPCServer new a gRPC server.
func NewGRPCServer(opts *Opts) (*grpc.Server, error) {
// Opt-in histogram metrics for the interceptor
grpc_prometheus.EnableHandlingTimeHistogram()

var serverOpts = []grpc.ServerOption{
grpc.Middleware(craftMiddleware(opts)...),
grpc.UnaryInterceptor(grpc_prometheus.UnaryServerInterceptor),
Expand Down