feat(controlplane): update org name #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
commented
Nov 27, 2023
| message Result { | ||
| User current_user = 1; | ||
| Org current_org = 2; | ||
| OrgItem current_org = 2; |
There was a problem hiding this comment.
this change it just to be consistent with the name of other resources in the proto defs
| service OrganizationService { | ||
| // List the organizations this user has access to | ||
| rpc ListMemberships (OrganizationServiceListMembershipsRequest) returns (OrganizationServiceListMembershipsResponse); | ||
| rpc Update (OrganizationServiceUpdateRequest) returns (OrganizationServiceUpdateResponse); |
There was a problem hiding this comment.
this is the actual new method
| return uc.orgRepo.Create(ctx, name) | ||
| } | ||
|
|
||
| func validateOrgName(name string) error { |
There was a problem hiding this comment.
and the new validation logic performed on creation and update.
Note that selecting the name on creation is not yet supported, but will.
That's why for the auto-generated names we make sure it complies with this new format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to update an existing organization name that the user is a member of.
This patch also adds some logic to perform the same validation Kubernetes has for the namespace names.
The reason to perform this validation is that later down the road, we'll add additional constraints to make sure the names are unique across the instance, can be used as part of a URL, and it can become an identifier on a declarative API.
Closes #448