Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

feat(ctag): add ctag component #146

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

Shyrro
Copy link
Contributor

@Shyrro Shyrro commented Jul 31, 2022

Signed-off-by: Shyrro zsahmane@gmail.com

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Current behavior of the tag is the same as the Tag in Chakra ui React.

Does this introduce a breaking change?

  • Yes
  • No

Other information

I noticed that Cypress tests were loading infinitely, so i opened another PR to fix them : (#147 )

Also, couldn't update the docs in the Vitepress, nothing showed up.

@vercel
Copy link

vercel bot commented Jul 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chakra-ui-vue-next ❌ Failed (Inspect) Aug 10, 2022 at 11:23PM (UTC)
chakra-ui-vue-next-playground ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 11:23PM (UTC)

Signed-off-by: Shyrro <zsahmane@gmail.com>
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Shyrro for this pull request!

I appreciate all the help you're lending to the project. The code on this PR looks pretty good. The only think I think that it's missing is a working deployment of the demos. It seems the rendering of the playground is broken on the deploy preview.

Do you think you could resolve that before we merge?

Signed-off-by: Shyrro <zsahmane@gmail.com>
@Shyrro
Copy link
Contributor Author

Shyrro commented Aug 10, 2022

Hi @codebender828 !

Seems that the playground was broken on develop so i fixed it in another PR (#151 ) but i cherry picked the commit in this PR so that you can check that the Tags are working fine.

Let me know if there is anything else that needs to be changed,

Thanks !

@codebender828
Copy link
Collaborator

Thank you @Shyrro ! Will go ahead and merge this

@codebender828 codebender828 merged commit 5bb76a0 into chakra-ui:develop Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants