-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): Add option to set max FPS #578
Conversation
Hey @muesli did you get a chance to look at this PR? |
I think this one makes sense. My only thought is that we probably want to cap the upper value to keep things from accidentally getting too outta control (so maybe And if we're clamping the values an |
7bf9be4
to
7897d94
Compare
@meowgorithm hey, can we merge this, please? Should I change anything? |
Hey there! Thanks for the ping and sorry for the delay on this. Will give it a re-review this week. |
Added the `WithMaxFPS` option to bubbletea program struct, if it is set with a non 0 value it will set the maximum interval at which the view is updated, if it is not set or set to 0, the interval will be the `defaultFramerate` constant.
Thanks for your patience, @tomfeigin. I've rebased Do you mind either ticking the box to allow me to push or resetting to the Anyway, let me know. |
7897d94
to
91b03ea
Compare
@meowgorithm Thank you! Done :) |
Awesome. Would ideally like to get @muesli’s approval as well. Mues, I played with this a bit and for me it’s working great. |
@muesli @meowgorithm, any updates on this? We really want to stop maintaining our fork |
@tomfeigin Apologies for the delay. We’re merging this today. |
Alrighty, you'll see this in the next release. Thanks for the PR! |
Solves issue #577
Added the
WithMaxFPS
WithFPS
option to bubbletea program struct, if it is set with a non 0 value it will set the maximum interval at which the view is updated, if it is not set or set to 0, the interval will be thedefaultFramerate
constant.