Skip to content

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Jul 6, 2025

Otherwise MDN signature is not checked and MDN is assigned to an email-contact.

Fixes #6947

@link2xt link2xt force-pushed the link2xt/read-receipt-contact branch 3 times, most recently from 57d1520 to d0d3629 Compare July 6, 2025 20:20
@link2xt link2xt force-pushed the link2xt/read-receipt-contact branch from d0d3629 to fd08fa0 Compare July 6, 2025 20:27
Copy link
Collaborator

@iequidoo iequidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment in render_mdn() tells: currently, we do not send MDNs encrypted:. Is this still true? Config::ProtectAutocrypt wouldn't work for MDNs if so.

Also, we could add some fingerprint header instead to MDNs to make them more lightweight, but adding "Autocrypt" is also fine.

@link2xt
Copy link
Collaborator Author

link2xt commented Jul 6, 2025

The comment in render_mdn() tells: currently, we do not send MDNs encrypted:. Is this still true? Config::ProtectAutocrypt wouldn't work for MDNs if so.

We send MDNs encrypted. I removed this outdated comment.

Also, we could add some fingerprint header instead to MDNs to make them more lightweight, but adding "Autocrypt" is also fine.

OpenPGP already has a packet for this. I opened an issue for using it: #6982
Adding Autocrypt header was just the easiest way to solve the issue.

@link2xt link2xt merged commit d9b361f into main Jul 6, 2025
53 of 54 checks passed
@link2xt link2xt deleted the link2xt/read-receipt-contact branch July 6, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read receipts are always associated to address-contacts

2 participants