fix: send Autocrypt header in MDNs

deltachat-rpc-client/src/deltachat_rpc_client/message.py

@@ -2,7 +2,7 @@
 
 import json
 from dataclasses import dataclass
-from typing import TYPE_CHECKING, Optional, Union
+from typing import TYPE_CHECKING, List, Optional, Union
 
 from ._utils import AttrDict, futuremethod
 from .const import EventType
@@ -39,6 +39,11 @@ def get_snapshot(self) -> AttrDict:
         snapshot["message"] = self
         return snapshot
 
+    def get_read_receipts(self) -> List[AttrDict]:
+        """Get message read receipts."""
+        read_receipts = self._rpc.get_message_read_receipts(self.account.id, self.id)
+        return [AttrDict(read_receipt) for read_receipt in read_receipts]
+
     def get_reactions(self) -> Optional[AttrDict]:
         """Get message reactions."""
         reactions = self._rpc.get_message_reactions(self.account.id, self.id)

deltachat-rpc-client/tests/test_something.py

@@ -726,6 +726,26 @@ def test_markseen_contact_request(acfactory):
     assert message2.get_snapshot().state == MessageState.IN_SEEN
 
 
+def test_read_receipt(acfactory):
+    """
+    Test sending a read receipt and ensure it is attributed to the correct contact.
+    """
+    alice, bob = acfactory.get_online_accounts(2)
+
+    alice_chat_bob = alice.create_chat(bob)
+    alice_contact_bob = alice.create_contact(bob)
+    bob.create_chat(alice)  # Accept the chat
+
+    alice_chat_bob.send_text("Hello Bob!")
+    msg = bob.wait_for_incoming_msg()
+    msg.mark_seen()
+
+    read_msg = alice.get_message_by_id(alice.wait_for_event(EventType.MSG_READ).msg_id)
+    read_receipts = read_msg.get_read_receipts()
+    assert len(read_receipts) == 1
+    assert read_receipts[0].contact_id == alice_contact_bob.id
+
+
 def test_get_http_response(acfactory):
     alice = acfactory.new_configured_account()
     http_response = alice._rpc.get_http_response(alice.id, "https://example.org")

src/mimefactory.rs

@@ -528,7 +528,7 @@ impl MimeFactory {
             Loaded::Message { msg, .. } => {
                 msg.param.get_bool(Param::SkipAutocrypt).unwrap_or_default()
             }
-            Loaded::Mdn { .. } => true,
+            Loaded::Mdn { .. } => false,
         }
     }
 
@@ -1712,16 +1712,6 @@ impl MimeFactory {
     fn render_mdn(&mut self) -> Result<MimePart<'static>> {
         // RFC 6522, this also requires the `report-type` parameter which is equal
         // to the MIME subtype of the second body part of the multipart/report
-        //
-        // currently, we do not send MDNs encrypted:
-        // - in a multi-device-setup that is not set up properly, MDNs would disturb the communication as they
-        //   are send automatically which may lead to spreading outdated Autocrypt headers.
-        // - they do not carry any information but the Message-ID
-        // - this save some KB
-        // - in older versions, we did not encrypt messages to ourself when they to to SMTP - however, if these messages
-        //   are forwarded for any reasons (eg. gmail always forwards to IMAP), we have no chance to decrypt them;
-        //   this issue is fixed with 0.9.4
-
         let Loaded::Mdn {
             rfc724_mid,
             additional_msg_ids,