Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requireIsAnnotatable for better errors when annotating literals #3968

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add requireIsAnnotatable for better errors when annotating literals #3968

merged 1 commit into from
Apr 5, 2024

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)

Desired Merge Strategy

  • Squash

Release Notes

This gives much better error messages when accidentally dontTouching a literal

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Feature New feature, will be included in release notes label Apr 4, 2024
@jackkoenig jackkoenig added this to the 5.x milestone Apr 4, 2024
seldridge
seldridge approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/src/main/scala/chisel3/dontTouch.scala Outdated Show resolved Hide resolved
@jackkoenig jackkoenig enabled auto-merge (squash) April 4, 2024 21:08
@jackkoenig jackkoenig merged commit 4be3b6f into main Apr 5, 2024
14 checks passed
@jackkoenig jackkoenig deleted the requireIsAnnotatable branch April 5, 2024 16:05
@mergify mergify bot added the Backported This PR has been backported label Apr 5, 2024
mergify bot pushed a commit that referenced this pull request Apr 5, 2024
@jackkoenig @mergify
Add requireIsAnnotatable for better errors when annotating literals (#…
e2a0b9e 
…3968)

(cherry picked from commit 4be3b6f)
mergify bot pushed a commit that referenced this pull request Apr 5, 2024
@jackkoenig @mergify
Add requireIsAnnotatable for better errors when annotating literals (#…
fe451e4 
…3968)

(cherry picked from commit 4be3b6f)

# Conflicts:
#	core/src/main/scala/chisel3/dontTouch.scala
#	src/test/scala/chiselTests/DontTouchSpec.scala
This was referenced Apr 5, 2024
Merged
Merged
chiselbot pushed a commit that referenced this pull request Apr 5, 2024
@mergify @jackkoenig
Add requireIsAnnotatable for better errors when annotating literals (#…
822a949 
…3968) (#3971)

(cherry picked from commit 4be3b6f)

Co-authored-by: Jack Koenig <koenig@sifive.com>
chiselbot pushed a commit that referenced this pull request Apr 5, 2024
@mergify @jackkoenig
Add requireIsAnnotatable for better errors when annotating literals (…
a53abb9 
…backport #3968) (#3970)

* Add requireIsAnnotatable for better errors when annotating literals (#3968)

(cherry picked from commit 4be3b6f)

# Conflicts:
#	core/src/main/scala/chisel3/dontTouch.scala
#	src/test/scala/chiselTests/DontTouchSpec.scala

* Resolve backport conflicts

---------

Co-authored-by: Jack Koenig <koenig@sifive.com>
SpriteOvO added a commit that referenced this pull request Apr 6, 2024
@SpriteOvO
Specify desiredName as defname for extmodule (#3958)
dc970d9 
* Specify right convention for modules

* Specify `desiredName` as `defname` for `extmodule`

Removed FixedPoint in muxes-and-input-selection.md (#3956)

Make SRAMs directly emit FIRRTL memories (#3955)

Add a new BoringUtils.drive API for boring to drive a sink. (#3960)

This API allows users to bore to a sink they plan to drive, which complements the existing API to bore from a source to read.

Support literals in DataView (#3964)

Add requireIsAnnotatable for better errors when annotating literals (#3968)
SpriteOvO pushed a commit that referenced this pull request Apr 8, 2024
@jackkoenig @SpriteOvO
Add requireIsAnnotatable for better errors when annotating literals (#…
53de230 
…3968)
SpriteOvO pushed a commit that referenced this pull request Apr 20, 2024
@jackkoenig @SpriteOvO
Add requireIsAnnotatable for better errors when annotating literals (#…
d36ec83 
…3968)
SpriteOvO pushed a commit that referenced this pull request Apr 20, 2024
@jackkoenig @SpriteOvO
Add requireIsAnnotatable for better errors when annotating literals (#…
97041fd 
…3968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Feature New feature, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackkoenig @seldridge