RUN-1310: Assert PortLocker::PortLocker, Histogram::Factory::Build #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domiii
commented
Feb 9, 2023
Domiii
commented
- https://linear.app/replay/issue/RUN-1217#comment-ac993670
- https://linear.app/replay/issue/RUN-1310/asserts-for-portlockerportlocker-and-nominalcpufrequency
…- RUN-801 RUN-860 RUN-861 RUN-862 RUN-872 (#252) * error handling for CDP sendMessage calls * first version of DOM picker now highlights node on hover * `Session.findMouseEvents` now working * implemented `wrapObjectGetObjectId` * WIP: DOM id management * WIP: `getObjectPreview` for DOM nodes (but disabled)
Fix build errors.
* added `makeDebuggeeValue` * big renaming/refactoring of `gReplayScript` object management * provide functions to easily look up objects by different inputs: * → NOTE: in the context of a `PAUSE`, for each `plainObject`, there could also be an `rrpObject` and a `cdpObject`. We need all three of those in different contexts. * basic previewBlinkObject * remove `getOrCreateInspectorDOMAgent`, `gLastCommandErrors`, unnecessary `try/catch` and comments; clean up and annotate TODOs with issues
…tor-request-body-data Add network request data support.
…n-1310-asserts-for-portlockerportlocker-and
wwwppp0801
pushed a commit
to wwwppp0801/chromium
that referenced
this pull request
Feb 13, 2023
This reverts commit ad191ff. Reason for revert: Break CI builder. Original change's description: > [lacros skew tests] Refresh skew tests for M111 > > This CL updates the ash version ['111.0.5522.0'] for Lacros version skew testing. > This cl only affect linux-lacros config builders like linux-lacros-tester-rel, > linux-lacros-rel. > This cl will certainly NOT affect Lacros on-device builders(lacros-amd64-generic-rel, > lacros-amd64-generic-chrome-skylab, etc) or any other platforms. > If this CL caused regressions, please revert and stop the autoroller > at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller > Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, > yjt@google.com. > > R=rubber-stamper@appspot.gserviceaccount.com > > Bug: None > Change-Id: I84c27c63724c9e18592a908f6f72666921afd4fe > Requires-Testing: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4140043 > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/branch-heads/5481@{chromium#149} > Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008} Bug: None Change-Id: Ia14ece1706dc872bd5e2052979d0a353dc6ab46f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4144418 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/branch-heads/5481@{chromium#152} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this pull request
Mar 7, 2023
The current numbering for the enum is not in sync with what exists at chrome/browser/ui/webui/new_tab_page/new_tab_page.mojom. We need to remove an entry from enums.xml or add an entry to the mojom. Since image sources are always set when they are used we should remove the unused enum. Verified locally using chrome://histograms (cherry picked from commit b7daaba) Change-Id: If3b237265576b3afbe42075809be1d52ffda9890 Bug: 1384258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4201000 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Paul Adedeji <pauladedeji@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1098205} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219892 Auto-Submit: Paul Adedeji <pauladedeji@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{chromium#152} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 8, 2023
If the email notification is turned off by the user, we show a different body message in the bookmark star entry dialog to better describe what will happen when the user initiates price tracking. (cherry picked from commit 764484f) Bug: 1374118, 1369746 Change-Id: Ic82842980ba51f5105ee5b09c9a975e094d42865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3953776 Reviewed-by: Mei Liang <meiliang@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1060063} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3964955 Auto-Submit: Zhiyuan Cai <zhiyuancai@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{chromium#152} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Mar 10, 2023
This seems to happen if we create the coordinator post-destroy. (cherry picked from commit 80d1a6a) Bug: 1366905 Change-Id: Icfdeb9219c59b6620ee3f8ec29727983c4f4b043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915271 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1050651} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917011 Commit-Queue: Krishna Govind <govind@chromium.org> Owners-Override: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5304@{chromium#152} Cr-Branched-From: 5d7b1fc-refs/heads/main@{#1047731}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 31, 2023
(cherry picked from commit 22cfd09) Bug: 1420697 Change-Id: I79ae0e05cf4bf3e4587f91c11b7c30369a0c8160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4299586 Reviewed-by: Wissem Gamra <wiss@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1111777} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4303612 Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Wissem Gamra <wiss@chromium.org> Cr-Commit-Position: refs/branch-heads/5615@{chromium#152} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
unicornx
pushed a commit
to unicornx/chromium
that referenced
this pull request
Apr 19, 2023
Change-Id: I210b6b816b08b6a2ea04f398f321819ba88b6d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3796719 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5195@{chromium#152} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
May 9, 2023
Fixes the typos. (cherry picked from commit a9a09e4) Bug: 1428762 Change-Id: Iba30fc8c1d8a79e27cddd252ce051941cffaf398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4381041 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Kevin Grosu <kgrosu@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1123664} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4385639 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Cr-Commit-Position: refs/branch-heads/5672@{#152} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
l0hn
pushed a commit
to l0hn/chromium_test
that referenced
this pull request
Jun 9, 2023
…efault to false Forgot to set the default value to false/disabled when landing cl. (cherry picked from commit f8b2699) Bug: 1434461, 1441180 Change-Id: I890bf3c0cdd1de71e4c3ffae81495799ef25ed04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4480709 Commit-Queue: Peilin Wang <peilinwang@google.com> Reviewed-by: Patrick Noland <pnoland@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1135999} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4493183 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{chromium#152} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 29, 2023
The regen_test_json function is intended to simplify the process of updating the test json files when making changes, but not intended to be left in when submitted. A use of it was accidentally committed in crrev.com/c/4632065. (cherry picked from commit 1c1e4d4) Bug: 1456553 Change-Id: I950fbd480baa600bdb00c2e7ed8b20bca195eb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4651991 Reviewed-by: Struan Shrimpton <sshrimp@google.com> Commit-Queue: Struan Shrimpton <sshrimp@google.com> Auto-Submit: Garrett Beaty <gbeaty@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1163047} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4651303 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5845@{chromium#152} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
debugeek
pushed a commit
to debugeek/chromium
that referenced
this pull request
Jul 6, 2023
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-beta-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib2eeb2513b08fe06a04e4fa8492b4b218ad12ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3606750 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5005@{chromium#152} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
Change-Id: Id81fd40f25a63838dbe9219f0d2f7ef7a46fa231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574208 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5790@{chromium#152} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
The local card save path in the autofill client now launches the bottom sheet when the flag is enabled. AutofillSaveCardUiInfo now creates an empty list of LegalMessageLine objects since no LegalMessageLines are provided on local save. Screenshot: https://screenshot.googleplex.com/5WMydzxLfZSWJ6n.png Enable chrome://flags#autofill-enable-payments-android-bottom-sheet on Chrome for Android while signed out to see this bottom sheet after filling a new credit card. (cherry picked from commit 14eeddf) Bug: 1479546 Change-Id: I7414cdc7dd4a5d14f09f955a0db281633e13282b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4803123 Reviewed-by: Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Slobodan Pejic <slobodan@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1193563} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4852299 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/branch-heads/5993@{chromium#152} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Roll Chrome Mac PGO profile from chrome-mac-6045-1696653512-ee7a0ed103ee233d7b9fe5e988c8fc20077f3837.profdata to chrome-mac-6045-1696675611-4a28a3e936e8d1ac634184ce611c1ffc55a5d734.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m119.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I901c66e20ff241cf2afb0e726932df7d15d92ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4920739 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#152} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
referenced
this pull request
in Pissandshittium/pissandshittium
Dec 8, 2023
In this CL, we rename dimen single_tab_card_top|bottom_margin_tablet to ntp_single_tab_card_top|bottom_margin, and sets different values on phones and tablets. This fix is for showing NTP with the single tab card when "surface polish" is disabled. On the home surface NTP, 2 row MVT is shown on phones, while 1 row MVT is shown on tablets. Screenshots: https://docs.google.com/document/d/1ScwaMC4LbwEh5Ta_EvT4Mub0fT39i82yqlKHSSRCquE/edit#bookmark=id.rl9ya610969o. (cherry picked from commit 790b8fc) Bug: 1498081 Change-Id: Ifff2c0f9146bd675b5a29474f93c3741bcd0ce35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4995350 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1218991} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002589 Reviewed-by: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/6099@{#152} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Mac PGO profile from chrome-mac-6167-1702057598-48a0f0ca7d9fab35cc7d60affaaa8484cfc1e074.profdata to chrome-mac-6167-1702079692-7201d22c47d52c38d47f00ccffd2e60261efa263.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I116d58e698f07c0355a5c0384809f969048c7930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5107191 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#152} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 26, 2024
The "Fill full address" should also be availably if the popup is triggered on a company field. Screenshot: https://screenshot.googleplex.com/BWgiUMTeXVrasmy (cherry picked from commit 5de83c4) Bug: 1521738 Change-Id: I1aba8b0e0d846676ef150dc6f1ef01c3624ae3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237025 Reviewed-by: Florian Leimgruber <fleimgruber@google.com> Reviewed-by: Bruno Braga <brunobraga@google.com> Commit-Queue: Dmitry Vykochko <vykochko@google.com> Reviewed-by: Jihad Hanna <jihadghanna@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1252185} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237139 Reviewed-by: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/branch-heads/6261@{#152} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable
pushed a commit
that referenced
this pull request
Feb 26, 2024
Commits rolled: https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfe25b59ba13..f23ada0aee4e Generated by: go/bbid/8755014027242006641 Change-Id: Ia9e9b96a3064a747c70505f58af1d8f4581d12aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5319512 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6312@{#152} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
Issue for the payments bottom sheet was caused by recalculating the initial height every time -viewIsAppearing is called. Keeping track of the value and reusing it fixed this issue. (cherry picked from commit 69ca772) Bug: 1469913 Change-Id: I64941cc7dc80473c3dd8414e0aa091be5f50037b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4771062 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Veronique Nguyen <veronguyen@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/heads/main@{#1182618} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4780552 Cr-Commit-Position: refs/branch-heads/5938@{chromium#152} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Mar 23, 2024
Roll src/third_party/dawn in M124 from c00db02cbbfe to 5767f7b088c0 Commits rolled: https://dawn.googlesource.com/dawn.git/+log/c00db02cbbfe..5767f7b088c0 Generated by: http://go/bbid/8752673605986177265 Change-Id: I09570a505b67dda738e41e51a124eee6ed53afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5388841 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#152} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 20, 2024
Roll Chrome Linux PGO profile from chrome-linux-6422-1713549065-fbf88c36a56ff02cb47025325c12dfee9ad3dbca-aee9613bd615ce50eeca32823aae3bad447da9dc.profdata to chrome-linux-6422-1713567885-2d166891a2cd5fa0f864857e699ab9d59b12d28e-0ab6714cb82e7c53ec442fa7ea9f34d7d12a333f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m125.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I144803d05e187ba795a9238ac5383adf431d4633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5469166 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#152} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 17, 2024
Roll src/clank in M126 from fcb6b842e3f0 to b032f5a1b9d2 Commits rolled: https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/fcb6b842e3f0..b032f5a1b9d2 Generated by: http://go/bbid/8747679448615147649 Change-Id: Id46e220b84d9fb0ed9a0cc01f0f29814cdae4498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5545326 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#152} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
May 18, 2024
CP approved at https://crbug.com/1293679#c34 1. As mentioned in https://crbug.com/1352366, - Set beacon request mode to `kCors`. - Set `request_initiator` to the last committed origin from the RFH of the beacon's host. - Set beacon request credentials mode to `kSameOrigin`. - Added some unit tests to cover the change 2. Updated c++ docs & mojom docs, and added unit tests that are missing from https://crrev.com/c/3826326 3. Made it impossible to reach NOTIMPLEMENTED() in PendingPostBeacon: A JS TypeError is already thrown when getting ReadableStream. (cherry picked from commit 11589ca) Bug: 1352366,1293679 Change-Id: Ic8b58d3d9f4aa9e1d47f4503fe65eda02d551e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838589 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ming-Ying Chung <mych@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Luca Hunkeler <hluca@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1038657} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3858832 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/branch-heads/5249@{chromium#152} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
aarongable
pushed a commit
that referenced
this pull request
Jun 15, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6533-1718365110-0b27e5a50dae004ebc57277d6a9d147c51f13747-c1f44dd334344750782afdf7a87a14946940ab28.profdata to chrome-mac-arm-6533-1718365110-504c57e8e0d5b91799f4c062ca16f5832848767a-c1f44dd334344750782afdf7a87a14946940ab28.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie7dd482861e6fffba2ff4ba7bd4b69956e691043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5633621 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6533@{#152} Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.