Merge PR #2349: Add missing event.setHandled() in MouseUp

andrewfb · andrewfb · commit 0597e8d7c13a · 2025-09-07T02:25:20.000Z
Completes the event propagation fix by adding the missing setHandled() call.
diff --git a/src/cinder/CinderImGui.cpp b/src/cinder/CinderImGui.cpp
@@ -374,6 +374,7 @@ static void ImGui_ImplCinder_MouseUp( ci::app::MouseEvent& event )
 	io.KeyShift = event.isShiftDown();
 	io.KeyAlt = event.isAltDown();
 	io.KeySuper = event.isMetaDown();
+	event.setHandled( io.WantCaptureMouse );
 }
 static void ImGui_ImplCinder_MouseWheel( ci::app::MouseEvent& event )
 {

Original file line number	Diff line number	Diff line change
`@@ -374,6 +374,7 @@ static void ImGui_ImplCinder_MouseUp( ci::app::MouseEvent& event )`
`374`	`374`	`io.KeyShift = event.isShiftDown();`
`375`	`375`	`io.KeyAlt = event.isAltDown();`
`376`	`376`	`io.KeySuper = event.isMetaDown();`
	`377`	`+ event.setHandled( io.WantCaptureMouse );`
`377`	`378`	`}`
`378`	`379`	`static void ImGui_ImplCinder_MouseWheel( ci::app::MouseEvent& event )`
`379`	`380`	`{`