Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a picture of a space or room if available #107

Open
zarp-dev opened this issue Sep 18, 2021 · 9 comments · May be fixed by #1076
Open

Show a picture of a space or room if available #107

zarp-dev opened this issue Sep 18, 2021 · 9 comments · May be fixed by #1076

Comments

@zarp-dev
Copy link

zarp-dev commented Sep 18, 2021

Is your feature request related to a problem? Please describe.

It is reasonable to make it so that if a room or space has a picture, the picture is displayed.

Describe the solution you'd like

Show a picture of the room (or space) if available, if not - show the default room (or space) icon
Screenshot 2021-09-19 at 14 57 52

If the room does not have a picture, show the default room icon in the header:
Screenshot 2021-09-19 at 23 43 54

@zarp-dev zarp-dev changed the title Add a setting to show pictures of rooms and spaces. Add a setting for displaying images of rooms and rooms Sep 18, 2021
@zarp-dev zarp-dev changed the title Add a setting for displaying images of rooms and rooms Add a setting for displaying images of rooms and DMs Sep 18, 2021
@zarp-dev zarp-dev changed the title Add a setting for displaying images of rooms and DMs Add a setting for displaying images of rooms and spaces Sep 18, 2021
@zarp-dev zarp-dev changed the title Add a setting for displaying images of rooms and spaces Setting for displaying images of rooms and spaces Sep 18, 2021
@zarp-dev zarp-dev changed the title Setting for displaying images of rooms and spaces Show a picture of a space or room if available Sep 19, 2021
@kfiven
Copy link
Collaborator

kfiven commented Oct 26, 2021

Blend of Pictures and Icons looks ugly as well as confusing. imho either we should keep all icons or all pictures.

Also room icon is visible after opening the room so I don't get why we need to duplicate it in drawer.

@Salamandar
Copy link

Salamandar commented Mar 16, 2022

Bump ! This is one of the few last things I prefer on Element ^^''

Also room icon is visible after opening the room so I don't get why we need to duplicate it in drawer.

Uh… Maybe because pictures are here to recognize/differentiate multiple rooms ?

@gabrc52
Copy link

gabrc52 commented Jan 14, 2023

Blend of Pictures and Icons looks ugly as well as confusing. imho either we should keep all icons or all pictures.

I agree but I would like this feature too, but the rooms in the proposed solution image dont look very clean to be honest. Spaces look great tho. This app has great design, which we don't want to break. Maybe all pictures (optional perhaps) would work

Also room icon is visible after opening the room so I don't get why we need to duplicate it in drawer.

What it would achieve: It gives you a birds eye view of the rooms you have. The room you're looking for catches your eye so you can click on it faster or find it faster.

@Salamandar
Copy link

Maybe all pictures (optional perhaps) would work

Yes, agreed. This could be a setting to let the user choose.

@Salamandar
Copy link

Salamandar commented Jan 14, 2023

Blend of Pictures and Icons looks ugly as well as confusing.

…That's already what we have for people. Do you find Cinny ugly and confusing for that ?

@Salamandar Salamandar linked a pull request Jan 14, 2023 that will close this issue
8 tasks
@Salamandar
Copy link

I've wrote #1076 that successfully fixes this issue. It doesn't let the user choose though, maybe @kfiven would like to contribute a setting for this ?

@kfiven
Copy link
Collaborator

kfiven commented Jan 14, 2023

Blend of Pictures and Icons looks ugly as well as confusing.

…That's already what we have for people. Do you find Cinny ugly and confusing for that ?

I meant a blend of icons and pictures in one list. That's why I said either we should have icons or just pictures.

@Salamandar
Copy link

Yes, i understood. In the people list, you might have their avatar or a color circle with a letter if they don't have an avatar. So we already have mixed display in Cinny.

greentore pushed a commit to greentore/greeny that referenced this issue Feb 13, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@belkka
Copy link

belkka commented Dec 15, 2023

I'll duplicate what I wrote in #1076:

Today I came to github only to fill a feature request on topic... but found this PR. I believe group avatars should be visible (isn't it their purpose?); it's so common and familiar for my friends potential users migrating from other popular messengers.

Current UI reminds channels in slack/discord spaces though — is it an actual motivation? In that case I do agree it's a nice feature, but I feel that:

  • it's only reasonable in spaces, not in global "home" list. Spaces do feel like slack/discord servers and UI with no room avatars could be fine for them because

    • spaces/servers already have icons
    • there are usually not much rooms within single space/server (easier to navigate) and they share common theme & community (lower risks of choosing wrong room)
    • having clean screen is also good (BTW, some discord servers use emoji in room names to compensate absence of icons)

    But "home" space feels more like a usual "chat-oriented" (rather than "space-oriented") messenger (Telegram, WhatsApp...) — a place where divergent uncategorized chats (communities) are shuffled together. This factor makes visual distinction more valuable. I'd say rooms outside of spaces are kind of "mini spaces" themself.

  • despite what has been said above, even with this PR being merged, space admins will be able to imitate slack/discord's look and feel if they like to... simply by not setting any room avatars and therefore keeping default hashtag icons!

I don't really want my matrix client hiding room avatars from me. And I really like Cinny, wish I could suggest it to my friends as a feature-rich alternative to messaging apps that do not respect privacy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants