Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Feb 19, 2020

🗣 Description

This PR pulls in upstream changes to cisagov/skeleton-python-library added in cisagov/skeleton-python-library#36.

💭 Motivation and Context

Keep it up to date!

🧪 Testing

Automated tests ran fine.

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

jsf9k and others added 26 commits January 24, 2020 16:45
A user forked cisagov/scan-target-data and created a pull request, but
the required GitHub Action(s) did not run.  This is presumably because
the user does not have Actions enabled in his or her fork.  Ideally,
the required Action(s) would run in cisagov/scan-target-data when a PR
to merge changes back is created.  Based on my reading of this link,
adding the "pull_request" event type should make this happen:
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-events-for-forked-repositories
…m-forked-repos

Make workflow run when a PR is opened, synchronized, or reopened
Cleanup Linux instructions and add WSL references to CONTRIBUTING.md
Update actions/checkout to v2
Update formatting to match downstream children
…n_and_checkout_action

Update Python and actions/checkout Versions
Update pre-commit hooks (and flip Actions cache order in workflow).
Add comment explaining why coveralls is being pinned.
…ates

Pull in Updates from skeleton-generic
@mcdonnnj mcdonnnj requested review from a team, dav3r, felddy and jsf9k as code owners February 19, 2020 19:29
@mcdonnnj mcdonnnj self-assigned this Feb 19, 2020
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the MAX!!!

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚒

@mcdonnnj mcdonnnj merged commit b8886c5 into develop Feb 19, 2020
@mcdonnnj mcdonnnj deleted the improvements/pull_in_upstream_changes branch February 19, 2020 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants