Skip to content

Structured output needs to handle nil value cases #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Structured output needs to handle nil value cases #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cisco_node_utils/client/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def self.filter_data(data: nil,
end
return final
end
fail "No key \"#{filter}\" in #{data}" if data[filter].nil?
fail "No key \"#{filter}\" in #{data}" unless data.key?(filter)
data = data[filter]
end
end
Expand Down
5 changes: 4 additions & 1 deletion lib/cisco_node_utils/node.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ def drill_down_structured(value, ref)
value = value.is_a?(Hash) ? [value] : value
data = nil
value.each do |row|
data = row[data_key] if row[row_key].to_s[/#{row_index}/]
if row[row_key].to_s[/#{row_index}/]
data = row[data_key]
data = data.nil? ? '' : data
end
end
return value if data.nil?
if regexp_filter
Expand Down