(FM-7109) Add ability to dynamically specify environment #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really use gRPC anymore, but until it's ripped out or re-purposed bump the version so it plays nice with current PE agentless
This commit adds basic functionality for passing in environment data at run time This is the building block for Puppet Device support
|
cc @willmeek |
willmeek
approved these changes
Aug 31, 2018
mikewiebe
reviewed
Sep 4, 2018
| '~> 0.2', '>= 0.2.1') | ||
| # NX-OS doesn't need gRPC | ||
| os == 'nexus' || deps << Gem::Dependency.new('grpc', '~> 0.12') | ||
| os == 'nexus' || deps << Gem::Dependency.new('grpc', '~> 1.14.1') |
There was a problem hiding this comment.
Are you testing XR in your environment?
There was a problem hiding this comment.
We are not testing / using this code w/ XR at all (to my knowledge)
There was a problem hiding this comment.
Ok.. just wondering why the version bump? We have considered removing support for this.
There was a problem hiding this comment.
When using Puppet Device it installs both gems. This is basically a temporary fix to unblock agentless. I agree we should probably remove the gRPC / XR stuff in the future.
|
@shermdog Looks good. Just a question about XR support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic functionality for passing in environment data at run time
This is the building block for Puppet Device support, but should not affect other consumers of the gem.