(NETDEV-37) Add support for hostname #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Customer request. Requires the release of netdev-stdlib and the merging of cisco/cisco-network-puppet-module#511 |
willmeek
force-pushed
the
NETDEV-37
branch
2 times, most recently
from
3639dac to
a7c9fd9
Compare
|
Closing this PR temporarily, we have changed the approach to hostname in netdev stdlib, need to rejig the logic here and reopen. Edit - Reopened, it appears that network_dns provider uses seperate node util classes for fields, we can leave this as is. |
willmeek
changed the title
|
👍 |
|
👍 |
|
@willmeek can you add CHANGELOG for this? |
This commit adds support for hostname, as used by network_dns type.
|
@shermdog Added a note to changelog, though the way it is structured is slightly different to netdev stdlib network_dns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a hostname provider, with a name string field.