Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

See how many tests fail with this check #20420

Closed
wants to merge 1 commit into from
Closed

See how many tests fail with this check #20420

wants to merge 1 commit into from

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented May 25, 2021

(Standard links)

@civibot civibot bot added the master label May 25, 2021
@seamuslee001
Copy link
Contributor

1902 failures

@eileenmcnaughton
Copy link
Contributor Author

Excluding syntax conformance now - also using apiv4 to avoid that first fail - although I note it shows an apiv3 bug - it check_permissions = FALSE is not getting the whole way down the v3 api Contribution query stack

CRM_Activity_BAO_ActivityTest::testTargetContactNotavaliable
Failure in api call for Contribution get: Undefined property: CRM_Core_Permission_UnitTests::$permissions
#0 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/CRM/Core/Permission/UnitTests.php(48): PHPUnit\Util\ErrorHandler->_invoke(8, 'Undefined prope...', '/home/jenkins/b...', 48, Array)
#1 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/CRM/Core/Permission.php(125): CRM_Core_Permission_UnitTests->check('all CiviCRM per...', NULL)
#2 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/CRM/Core/Permission.php(218): CRM_Core_Permission::check(Array)
#3 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/CRM/Core/Permission.php(264): CRM_Core_Permission::customGroupAdmin()
#4 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php(377): CRM_Core_Permission::customGroupClause(2, 'civicrm_custom...')
#5 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php(591): CRM_Core_BAO_CustomField::getFields(Array, false, false, NULL, NULL, false, false, true)
#6 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/CRM/Contribute/BAO/Query.php(872): CRM_Core_BAO_CustomField::getFieldsForImport('Contribution')
#7 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/api/v3/Contribution.php(250): CRM_Contribute_BAO_Query::defaultReturnProperties(2)
#8 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_contribution_get(Array)
#9 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/Civi/API/Kernel.php(149): Civi\API\Provider\MagicFunctionProvider->invoke(Array)
#10 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest(Array)
#11 /home/jenkins/bknix-dfl/build/core-20420-2pveb/web/sites/all/modules/civicrm/api/api.php(22): Civi\API\Kernel->runSafe('Contribution', 'get', Array)

@eileenmcnaughton
Copy link
Contributor Author

I'll re-test once #20415 is merged

@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

CRM_Contribute_BAO_ContributionRecurTest.testAutoRenewalWhenOneMemberIsDeceased
CRM_Core_BAO_MessageTemplateTest.testContactTokens
CRM_Core_Payment_BaseIPNTest.testThatCancellingEventPaymentWillCancelAllAdditionalPendingParticipantsAndCreateCancellationActivities
CRM_Event_BAO_ChangeFeeSelectionTest.testCRM19273
CRM_Event_BAO_ChangeFeeSelectionTest.testCRM17151
CRM_Event_Form_Registration_ConfirmTest.testPaidSubmit with data set #0
CRM_Event_Form_Registration_ConfirmTest.testPaidSubmit with data set #1
CRM_Event_Form_Registration_ConfirmTest.testTaxMultipleParticipant
CRM_Financial_BAO_FinancialItemTest.testAdd
CRM_Financial_BAO_FinancialItemTest.testRetrieve
CRM_Financial_BAO_FinancialItemTest.testCreate
CRM_Member_Form_MembershipTest.testFinancialEntriesOnCancelledContribution
CRM_Member_Form_MembershipTest.testTwoInheritedMembershipsViaPriceSetInBackend
CRM_Member_Form_MembershipTest.testTwoMembershipsViaPriceSetInBackendWithDiscount
CRM_Member_Form_MembershipTest.testContributionFormStatusUpdate
CRM_Member_Form_MembershipTest.testCreatePendingWithMultipleTerms
CRM_Report_Form_Contribute_DetailTest.testReportOutput with data set #0
CRM_Report_Form_Contribute_DetailTest.testPostalCodeSearchReportOutput with data set #0
CRM_Report_Form_Contribute_DetailTest.testMultipleSoftCredits
CRM_Report_Form_Contribute_DetailTest.testContributeDetailReportWithNewColumnFromCustomTable
CRM_Report_Form_TestCaseTest.testReportOutput with data set #0
CRM_Report_Form_TestCaseTest.testReportOutput with data set #1
CRM_Report_Form_TestCaseTest.testReportOutput with data set #2
CRM_Report_Form_TestCaseTest.testBadReportOutput with data set #0
CRM_Report_Form_TestCaseTest.testBadReportOutput with data set #1
api_v3_ACLPermissionTest.testEntitiesGetHookLimitingHookNoCheck with data set #0
api_v3_ACLPermissionTest.testEntitiesGetCoreACLLimitingHookNoCheck with data set #0
api_v3_ACLPermissionTest.testEntitiesGetCoreACLLimitingCheck with data set #0
api_v3_LineItemTest.testDeleteLineItem with data set "APIv3"
api_v3_LineItemTest.testDeleteLineItem with data set "APIv4"
api_v3_MembershipTest.testActivityForCancelledContribution
api_v3_PaymentTest.testRefundPaymentWithCancelledPaymentId
api_v3_ProfileTest.testLegacySet
api_v3_ProfileTest.testContactActivitySubmitWithoutActivityId
api_v3_ProfileTest.testContactActivitySubmitWrongActivityId
api_v3_ProfileTest.testContactActivitySubmitWrongActivityType
api_v3_ProfileTest.testContactActivitySubmitSuccess
api_v3_ProfileTest.testProfileApplyWithoutProfileId
api_v3_ProfileTest.testProfileApplyInvalidProfileId
api_v3_ProfileTest.testProfileApply
api_v3_ProfileTest.testSubmitWithTags
api_v3_ProfileTest.testSubmitWithNote
api_v3_ProfileTest.testSubmitGreetingFields

@eileenmcnaughton
Copy link
Contributor Author

I'm fairly sure these 3 represent real bugs
CRM_Core_Payment_BaseIPNTest.testThatCancellingEventPaymentWillCancelAllAdditionalPendingParticipantsAndCreateCancellationActivities
CRM_Event_BAO_ChangeFeeSelectionTest.testCRM19273
CRM_Event_BAO_ChangeFeeSelectionTest.testCRM17151

eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request May 29, 2021
@eileenmcnaughton
Fix profile test teardown
9db37f9 
This should make civicrm#20420 pass
for this class
@eileenmcnaughton eileenmcnaughton mentioned this pull request May 29, 2021
Merged
@seamuslee001
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor Author

api_v3_ACLPermissionTest.testEntitiesGetHookLimitingHookNoCheck with data set #0
api_v3_ACLPermissionTest.testEntitiesGetCoreACLLimitingHookNoCheck with data set #0
api_v3_ACLPermissionTest.testEntitiesGetCoreACLLimitingCheck with data set #0
api_v3_LineItemTest.testDeleteLineItem with data set "APIv3"
api_v3_LineItemTest.testDeleteLineItem with data set "APIv4"
api_v3_MembershipTest.testActivityForCancelledContribution
api_v3_PaymentTest.testRefundPaymentWithCancelledPaymentId
CRM_Contribute_BAO_ContributionRecurTest.testAutoRenewalWhenOneMemberIsDeceased
CRM_Core_Payment_BaseIPNTest.testThatCancellingEventPaymentWillCancelAllAdditionalPendingParticipantsAndCreateCancellationActivities
CRM_Event_BAO_ChangeFeeSelectionTest.testCRM19273
CRM_Event_BAO_ChangeFeeSelectionTest.testCRM17151
CRM_Event_Form_Registration_ConfirmTest.testPaidSubmit with data set #0
CRM_Event_Form_Registration_ConfirmTest.testPaidSubmit with data set #1
CRM_Event_Form_Registration_ConfirmTest.testTaxMultipleParticipant
CRM_Financial_BAO_FinancialItemTest.testAdd
CRM_Financial_BAO_FinancialItemTest.testRetrieve
CRM_Financial_BAO_FinancialItemTest.testCreate
CRM_Member_Form_MembershipTest.testFinancialEntriesOnCancelledContribution
CRM_Member_Form_MembershipTest.testTwoInheritedMembershipsViaPriceSetInBackend
CRM_Member_Form_MembershipTest.testTwoMembershipsViaPriceSetInBackendWithDiscount
CRM_Member_Form_MembershipTest.testContributionFormStatusUpdate
CRM_Member_Form_MembershipTest.testCreatePendingWithMultipleTerms
CRM_Report_Form_Contribute_DetailTest.testReportOutput with data set #0
CRM_Report_Form_Contribute_DetailTest.testPostalCodeSearchReportOutput with data set #0
CRM_Report_Form_Contribute_DetailTest.testMultipleSoftCredits
CRM_Report_Form_Contribute_DetailTest.testContributeDetailReportWithNewColumnFromCustomTable
CRM_Report_Form_TestCaseTest.testReportOutput with data set #0
CRM_Report_Form_TestCaseTest.testReportOutput with data set #1
CRM_Report_Form_TestCaseTest.testReportOutput with data set #2
CRM_Report_Form_TestCaseTest.testBadReportOutput with data set #0
CRM_Report_Form_TestCaseTest.testBadReportOutput with data set #1

@eileenmcnaughton
Copy link
Contributor Author

I'm not actively working on this this week so it doesn't belong in the review queue at the moment

This was referenced Jun 7, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001