Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Commit 88630b7

Browse files
authored
Merge pull request #1129 from ckeditor/t/1126
Fix: Spaces inside `<code>` will be rendered in a normal way (previously `DomConverter` tried to treat `<code>` like a preformatted block which is not what HTML requires). Closes #1126.
2 parents 3492420 + 9220a9d commit 88630b7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/view/domconverter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export default class DomConverter {
6565
*
6666
* @member {Array.<String>} module:engine/view/domconverter~DomConverter#preElements
6767
*/
68-
this.preElements = [ 'pre', 'code' ];
68+
this.preElements = [ 'pre' ];
6969

7070
/**
7171
* Tag names of DOM `Element`s which are considered block elements.

tests/view/domconverter/view-to-dom.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -413,11 +413,11 @@ describe( 'DomConverter', () => {
413413
} );
414414

415415
it( 'text node before in a preformatted node', () => {
416-
const viewCode = new ViewAttributeElement( 'code', null, new ViewText( 'foo ' ) );
416+
const viewCode = new ViewAttributeElement( 'pre', null, new ViewText( 'foo ' ) );
417417
const viewDiv = new ViewContainerElement( 'div', null, [ viewCode, new ViewText( ' bar' ) ] );
418418
const domDiv = converter.viewToDom( viewDiv, document );
419419

420-
expect( domDiv.innerHTML ).to.equal( '<code>foo </code> bar' );
420+
expect( domDiv.innerHTML ).to.equal( '<pre>foo </pre> bar' );
421421
} );
422422
} );
423423
} );

0 commit comments

Comments
 (0)