Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Commit 524586b

Browse files
authored
Merge pull request #196 from ckeditor/t/ckeditor5/1151
Other: Adjusted `InsertTableView` for better compatibility with right–to–left (RTL) languages. See ckeditor/ckeditor5#1151.
2 parents 4569d21 + 92d8f87 commit 524586b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/ui/inserttableview.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export default class InsertTableView extends View {
5959
* @member {String} #label
6060
*/
6161
this.bind( 'label' )
62-
.to( this, 'columns', this, 'rows', ( columns, rows ) => `${ rows } x ${ columns }` );
62+
.to( this, 'columns', this, 'rows', ( columns, rows ) => `${ rows } × ${ columns }` );
6363

6464
this.setTemplate( {
6565
tag: 'div',

tests/ui/inserttableview.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ describe( 'InsertTableView', () => {
3939
} );
4040

4141
it( 'sets #label to default rows & columns', () => {
42-
expect( view.label ).to.equal( '0 x 0' );
42+
expect( view.label ).to.equal( '0 × 0' );
4343
} );
4444

4545
it( 'creates #element from template', () => {
@@ -85,11 +85,11 @@ describe( 'InsertTableView', () => {
8585
it( 'binds #label to rows & columns', () => {
8686
view.rows = 3;
8787

88-
expect( view.label ).to.equal( '3 x 0' );
88+
expect( view.label ).to.equal( '3 × 0' );
8989

9090
view.columns = 7;
9191

92-
expect( view.label ).to.equal( '3 x 7' );
92+
expect( view.label ).to.equal( '3 × 7' );
9393
} );
9494

9595
it( 'mousedown event should be prevented', () => {

0 commit comments

Comments
 (0)