Merge pull request #251 from ckeditor/t/249

Fix: DropdownView should open upon arrow down key press. Closes #249.

Author: oskarwrobel

src/dropdown/dropdownview.js

@@ -98,34 +98,6 @@ export default class DropdownView extends View {
 
 		// Toggle the visibility of the panel when the dropdown becomes open.
 		panelView.bind( 'isVisible' ).to( this, 'isOpen' );
-
-		/**
-		 * The label of the dropdown.
-		 *
-		 * @observable
-		 * @member {String} #label
-		 */
-
-		/**
-		 * Controls whether the dropdown is enabled (can be clicked).
-		 *
-		 * @observable
-		 * @member {Boolean} #isEnabled
-		 */
-
-		/**
-		 * Controls whether the {@link #buttonView} is "pushed".
-		 *
-		 * @observable
-		 * @member {Boolean} #isOn
-		 */
-
-		/**
-		 * (Optional) Whether the label of the dropdown is visible. See {@link module:ui/button/buttonview~ButtonView#withText}.
-		 *
-		 * @observable
-		 * @member {Boolean} #withText
-		 */
 	}
 
 	/**
@@ -149,7 +121,7 @@ export default class DropdownView extends View {
 		// Open the dropdown panel using the arrow down key, just like with return or space.
 		this.keystrokes.set( 'arrowdown', ( data, cancel ) => {
 			// Don't open if the dropdown is disabled or already open.
-			if ( this.isEnabled && !this.isOpen ) {
+			if ( this.buttonView.isEnabled && !this.isOpen ) {
 				this.isOpen = true;
 				cancel();
 			}

tests/dropdown/dropdownview.js

@@ -127,7 +127,7 @@ describe( 'DropdownView', () => {
 					stopPropagation: sinon.spy()
 				};
 
-				view.isEnabled = true;
+				view.buttonView.isEnabled = true;
 
 				view.isOpen = true;
 				view.keystrokes.press( keyEvtData );
@@ -149,7 +149,7 @@ describe( 'DropdownView', () => {
 					stopPropagation: sinon.spy()
 				};
 
-				view.isEnabled = false;
+				view.buttonView.isEnabled = false;
 				view.isOpen = false;
 
 				view.keystrokes.press( keyEvtData );