-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i/5201: Add ImageResizeUI
plugin.
#7482
Conversation
This is still WIP:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior is cool and works well :)
The comments in the code are mostly cosmetic.
UI/UX part
- The label alignment in dropdown feels weird to me:
2. Buttons in the toolbar have repeated icons.
I don't have better option for this in my mind but (maybe as a follow up) - do you think that we could have here something less cluttered with duplicated arrows icons. My initial thought on this is some kind of "inner toolbar"
icon btn_original btn_50 btn_75
So it would have always an icon, then configured buttons.
The other idea is to have icon display configurable for those buttons so it would not add them.
ps.: The UI questions are rather hints/suggestions as I don't feel strong in that field.
@jodator I fixed most of the issues. Still to do:
I'll take care of these on Monday. |
Regarding the plugin icon... I was thinking about something like this: but just after I implemented it, I'm not so sure anymore... @jodator WDYT? |
Kinda OK and kind not OK - but again, I don't think I'm the best one to judge UI ;) Looks better but it brings new UI pattern - which should be probably discussed. And since we have problem with this maybe let's go with label buttons for now and make the UI refinement in a follow-up. WDYTAT? |
I'm OK with that 👌 |
One thing slipped: Plus some cosmetics to the docs and class layout: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️
Thanks for catching those issues 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, grab a 🍪
Suggested merge commit message (convention)
Feature (image): Introduced the UI for a manual image resizing via a dropdown or standalone buttons depends on the configuration. Closes #5201. Closes #5197.
Additional information
The PR also updates
Image
plugin configuration API, by adding a new propertyimageResizeOptions
.