fix: string inputs

Parse start and end options to float.

Fixes #25

Author: cladera

src/plugin.js

@@ -69,8 +69,8 @@ const offset = function(options) {
   options = options || {};
   const Player = this.constructor;
 
-  this._offsetStart = options.start || 0;
-  this._offsetEnd = options.end || 0;
+  this._offsetStart = parseFloat(options.start || '0');
+  this._offsetEnd = parseFloat(options.end || '0');
   this._restartBeginning = options.restart_beginning || false;
 
   if (!Player.__super__ || !Player.__super__.__offsetInit) {
@@ -92,10 +92,15 @@ const offset = function(options) {
     Player.prototype.currentTime = function(seconds) {
       if (seconds !== undefined) {
         return Player.__super__.currentTime
-          .call(this, seconds + this._offsetStart) - this._offsetStart;
+          .call(this, seconds + this._offsetStart);
       }
-      return Player.__super__.currentTime
-        .apply(this, arguments) - this._offsetStart;
+      const curr = Player.__super__.currentTime
+        .apply(this);
+
+      if (curr > this._offsetStart) {
+        return curr - this._offsetStart;
+      }
+      return 0;
     };
 
     Player.prototype.remainingTime = function() {

test/karma.conf.js

@@ -1,26 +1,21 @@
 module.exports = function(config) {
-  var detectBrowsers = {
-    enabled: false,
-    usePhantomJS: false
-  };
-
   // On Travis CI, we can only run in Firefox and Chrome; so, enforce that.
   if (process.env.TRAVIS) {
     config.browsers = ['Firefox', 'travisChrome'];
   }
 
-  // If no browsers are specified, we enable `karma-detect-browsers`
-  // this will detect all browsers that are available for testing
+  // If no browsers are specified, assume is dev env and run ChromeHeadless
+  // TODO: re-enable detect browsers when figure out how to make test work in
+  // Safari
   if (!config.browsers.length) {
-    detectBrowsers.enabled = true;
+    config.browsers = ['ChromeHeadless']
   }
 
   config.set({
     basePath: '..',
-    frameworks: ['qunit', 'detectBrowsers'],
+    frameworks: ['qunit'],
     files: [
       'node_modules/video.js/dist/video-js.css',
-      
       'node_modules/es5-shim/es5-shim.js',
       'node_modules/sinon/pkg/sinon.js',
       'node_modules/video.js/dist/video.js',
@@ -32,7 +27,6 @@ module.exports = function(config) {
         flags: ['--no-sandbox']
       }
     },
-    detectBrowsers: detectBrowsers,
     reporters: ['dots'],
     port: 9876,
     colors: true,

test/plugin.test.js

@@ -59,3 +59,29 @@ QUnit.test('registers itself with video.js', function(assert) {
     'the plugin alters video duration adjusting to start|end options'
   );
 });
+
+QUnit.test('configure start and end as as strings', function(assert) {
+  assert.expect(2);
+
+  assert.strictEqual(
+    typeof Player.prototype.offset,
+    'function',
+    'videojs-offset plugin was registered'
+  );
+
+  this.player.offset({
+    start: '10.5',
+    end: '300.5'
+  });
+
+  // Tick the clock forward enough to trigger the player to be "ready".
+  this.clock.tick(1);
+
+  this.player.currentTime(2);
+
+  assert.ok(
+    this.player.currentTime() === 2,
+    'the plugin alters seeking by applying the start correction'
+  );
+});
+