-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TopEntity
annotation docs to include Enable parameter
#1736
Conversation
There are a couple of examples like: clash-compiler/clash-prelude/src/Clash/Annotations/TopEntity.hs Lines 278 to 280 in a737df6
Those ANNotations should be on |
I've now updated those as well |
I was just trying the first example of Portname: data T = MkT Int Bool
{-# ANN f (defSyn "f") #-}
f :: Int -> T -> (T,Bool)
f a b = (b,True) First of all the output doesn't match what is in the documentation: entity f is
port(a : in signed(63 downto 0);
b_0 : in signed(63 downto 0);
b_1 : in boolean;
result : out std_logic_vector(65 downto 0));
end; But what is surprising is that it unpacks the input T into two ports, but not the output T. |
The later examples are also slightly wrong, clash doesn't use types like |
@leonschoorl can you just fix the issues yourself? :) |
That's because Perhaps we should use |
I went through all the examples in the TopEntity module and updated them and their output. |
Fixes #654