-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast binary-cached build of clawpack dependencies #499
Conversation
Just a summary of what I've done:
Everything looks like it's working, but I don't think I have a complete dependency list. I guess the idea would be to use hashdist now as the only test environment (don't run separate pyclaw/petclaw tests). I can do this, but I'd like to put together a list of all dependencies before we merge them. Also, I suspect that the parallel tests will screw up the coverage output, so we should run the parallel tests first, then run the serial tests afterwards just to generate correct coverage scores. |
@certik - You might be interested in seeing this. The binary cache of a 45 minute hashdist build takes about 2 seconds to download from Dropbox to Travis. |
Wow, 4-minute builds on Travis. This is exciting! I think the only dependency you are missing is scipy (which is why tests are still being skipped). Here is my list:
|
Nice!! We need to get binary builds officially supported. Sent from my mobile phone.
|
I still can't get over how fast the binary caches are, four seconds to get the entire scipy + petsc4py + h5py stack loaded on Travis. |
I left off python-coveralls/coverage because I wasn't sure whether they were needed on the Travis side or our builds. I think we can safely just move the |
Okay I think this is ready for review/merge assuming the 5-minute builds pass :) |
By the way, it looks like there's a failing parallel 3-D test that the tests are exposing. |
That didn't work, hold on. |
@ketch - As far as I can tell, coverage tools are running correctly on the Travis side, but Coveralls is not reporting any coverage. I don't have more time to work on this project this week, and this is otherwise ready to merge. Can you take it from here? |
Looks like something changed sizes in the parallel tests for some reason. |
@mandli - I'm pretty sure that's a test that wasn't being run before. And that issue is probably easily fixed by correctly running the verification in parallel. We would have caught it sooner if we had a full testing stack running on Travis. |
Great! It would be nice if this worked on SageMathCloud too.
On Sun, Jan 18, 2015 at 12:36 AM, Ondřej Čertík notifications@github.com
|
I had already detected this test failure and posted an issue: The problem is simply that our hdf5 writer does not work correctly in parallel. I think Coveralls is not reporting coverage because the parallel tests are failing. I think we should merge this PR and then fix that test afterward. The question I have is for @ahmadia: do you think it is a good idea to rely on your dropbox account for this? Should we upload the stack to clawpack.github.io or somewhere like that? |
Also, @ahmadia it is probably best to just skip this test in parallel on Travis for now, so we don't merge a broken build. |
If the Clawpack organization ends up getting some sponsored storage from Amazon, I would be happy to have the stack live there. It's okay on Dropbox for now. The Dropbox account is on S3, and there's a good chance the Travis bots are spawning on EC2. Data transfer across S3 to an EC2 instance in the same region is actually free, but I couldn't tell you where my Dropbox storage or the Travis bots live. Otherwise, it's about 2 cents per GB. Given that the total hashstack build is about 150 MB, it works out to about 300 Travis builds per $1 of storage costs. I'm guessing we don't cost Dropbox/Travis more than $5 a year based on this off-the-cuff calculation. I have a professional Dropbox account, so hopefully I'm paying for this sort of thing anyway :) |
Not quite a SkipTest, but this would be complicated to do with the gen_variants framework right now, so I'm going to leave it.
I can't quite run a SkipTest, but petclaw is now disabled for the Sedov test. |
Fast binary-cached build of clawpack dependencies
@ketch - thanks for merging, looks like coveralls/coverage is still not working correctly. |
@ahmadia Yes, but that seems to have been broken for a while now. Probably since I turned on doctests. Actually, it was never completely working correctly. I will raise an issue. |
We should discuss this before merging it, as well as figure out what clawpack dependencies we want to put in.