Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #232

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Update README.md #232

merged 1 commit into from
Jul 7, 2020

Conversation

rjleveque
Copy link
Member

Add Contents section copied from Index.ipynb

Add Contents section copied from Index.ipynb
@ketch
Copy link
Member

ketch commented Jul 7, 2020

This seems fine; I find that occasionally Github is slow to render notebooks or even fails. That mostly happens with large notebooks so probably wouldn't affect the index, but this just potentially makes it easier for some people to access.

@ketch ketch merged commit 423397d into master Jul 7, 2020
@ketch
Copy link
Member

ketch commented Jul 7, 2020

Now that I merged it I just realized that it doesn't include the hyperlinks -- was that intended? I think we should include the links; if you agree then I can do that.

@maojrs
Copy link
Contributor

maojrs commented Jul 7, 2020

I think we should definitely include the links.

@rjleveque
Copy link
Member Author

rjleveque commented Jul 7, 2020 via email

@maojrs
Copy link
Contributor

maojrs commented Jul 8, 2020

Ohh I see. In that case I think it is also ok as it is now.

@ketch
Copy link
Member

ketch commented Jul 8, 2020

What if I change the chapter names in the TOC at the bottom of the README to be the actual notebook file names (in backticks), so it's completely clear which notebook is referred to?

@rjleveque
Copy link
Member Author

@ketch - Yes, that sounds like a great solution.

@ketch
Copy link
Member

ketch commented Jul 9, 2020

Okay, I went ahead and just edited the README directly.

@ketch ketch deleted the rjleveque-readme-contents branch July 9, 2020 07:28
@rjleveque
Copy link
Member Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants