fix(repo): Address e2e failures #6867
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated Verdaccio devDependency to 6.1.6 in Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor GH as GitHub Actions Runner
participant Repo as Repository
participant PNPM as pnpm
participant Registry as Package Registry
GH->>Repo: checkout
GH->>PNPM: pnpm config set minimum-release-age-exclude @clerk/* %%{bg: #E6F4EA}%%
GH->>PNPM: pnpm install / pnpm add @clerk/backend or @clerk/clerk-js
PNPM->>Registry: fetch packages
Registry-->>PNPM: packages
PNPM-->>GH: install complete
note right of GH: Steps run only if affected== '1'
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
352-359: Use Node to parsepackage.jsoninstead of regex.Grep/sed against JSON is fragile—minor formatting changes or additional
namekeys will leavepkg_name/pkg_versionempty and silently skip the tag update. We already have Node available; parsing through it keeps this step robust.- pkg_name=$(grep -o '"name": "[^"]*"' "$pkg_dir/package.json" | sed 's/"name": "//' | sed 's/"//') - pkg_version=$(grep -o '"version": "[^"]*"' "$pkg_dir/package.json" | sed 's/"version": "//' | sed 's/"//') + pkg_path="${pkg_dir%/}/package.json" + pkg_name=$(PKG_PATH="./${pkg_path}" node -pe 'const pkg=require(process.env.PKG_PATH); console.log(pkg.name ?? "");') + pkg_version=$(PKG_PATH="./${pkg_path}" node -pe 'const pkg=require(process.env.PKG_PATH); console.log(pkg.version ?? "");')
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.github/workflows/ci.yml(1 hunks)verdaccio.publish.yaml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
verdaccio.publish.yaml
.github/workflows/*.yml
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
CI/CD must be configured with GitHub Actions.
Files:
.github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (31)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (custom, chrome)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (handshake, chrome)
- GitHub Check: Integration Tests (handshake:staging, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (sessions:staging, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Unit Tests (22, **)
- GitHub Check: Static analysis
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: semgrep/ci
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
verdaccio.publish.yaml (1)
12-12: LGTM for Verdaccio unpublish permissions.This aligns with the new dist-tag workflow step and ensures Verdaccio will accept the tag updates.
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
CI/CD must be configured with GitHub Actions.
Files:
.github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
jacekradko
force-pushed
the
fix/e2e-failures
branch
from
b1cdd8c to
7211430
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
351-356: Remove dead commented block or replace with a rationaleThe commented‑out .npmrc edits add noise. Either remove them or include a brief comment explaining why the CLI
pnpm config setapproach is preferred here (temp projects outside the workspace).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/ci.yml(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.github/workflows/*.yml
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
CI/CD must be configured with GitHub Actions.
Files:
.github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (31)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (custom, chrome)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (handshake:staging, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (handshake, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (sessions:staging, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Unit Tests (22, **)
- GitHub Check: Static analysis
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
.github/workflows/ci.yml (2)
360-363: Prevent CI hangs and quote the glob pattern
pnpm initcan prompt interactively and hang CI. Also, the unquoted@clerk/*may be expanded by the shell. Initialize non‑interactively and quote the value.- pnpm init - pnpm config set minimum-release-age-exclude @clerk/* + # Create a minimal package.json non‑interactively + npm init -y >/dev/null 2>&1 || echo '{"name":"integration-tmp","version":"0.0.0","private":true}' > package.json + # Ensure the pattern isn't expanded by the shell + pnpm config set minimum-release-age-exclude "@clerk/*"
369-372: Repeat: avoid interactive init and quote the globSame issues as above in the temp clerk‑js workspace. Make it non‑interactive and quote the config value.
- mkdir clerk-js && cd clerk-js - pnpm init - pnpm config set minimum-release-age-exclude @clerk/* + mkdir clerk-js && cd clerk-js + npm init -y >/dev/null 2>&1 || echo '{"name":"clerk-js-tmp","version":"0.0.0","private":true}' > package.json + pnpm config set minimum-release-age-exclude "@clerk/*"
| # - name: Configure pnpm to ignore minimum release age for @clerk packages | ||
| # if: ${{ steps.task-status.outputs.affected == '1' }} | ||
| # run: | | ||
| # echo "minimum-release-age-exclude=@clerk/*" >> .npmrc | ||
| # pnpm config set minimum-release-age-exclude @clerk/* |
4 participants
Description
Fixing how we load packages from the Verdaccio local registry by adding override to our minimum package age for
@clerk/*modules. Without this setting, pnpm will refuse to install just published packagesAlso updated verdaccio to latest major as there are no breaking changes
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Chores
New Features