Skip to content

Conversation

jacekradko
Copy link
Member

@jacekradko jacekradko commented Sep 27, 2025

Description

Related: #6867

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Streamlined the continuous integration workflow by removing a redundant step related to package release-age configuration.
    • Consolidated configuration within existing install steps to reduce duplication and simplify maintenance.
    • No changes to app features, behavior, or release artifacts.
    • Build, test execution, and deployment remain unaffected.

Copy link

changeset-bot bot commented Sep 27, 2025

⚠️ No Changeset found

Latest commit: d5aba26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Sep 27, 2025 1:30pm

Copy link
Contributor

coderabbitai bot commented Sep 27, 2025

Walkthrough

Removed a standalone pnpm configuration step in .github/workflows/ci.yml that previously set minimum-release-age exclusions for @clerk packages. The workflow now relies on flags provided in subsequent install steps. No other jobs, conditionals, or error-handling paths were altered.

Changes

Cohort / File(s) Summary of Changes
CI workflow cleanup
\.github/workflows/ci.yml
Deleted a dedicated step that configured pnpm to ignore minimum release age for @clerk packages; retained equivalent exclusion via install step flags. No other workflow logic changed.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Dev as Developer
    participant GH as GitHub Actions
    participant CI as CI Job
    participant PNPM as pnpm

    Dev->>GH: Push / PR
    GH->>CI: Trigger workflow
    CI->>PNPM: Setup pnpm
    Note over CI,PNPM: Removed: standalone pnpm config step for min-release-age exclude
    CI->>PNPM: pnpm install (with minimum-release-age-exclude flags)
    CI->>CI: Build / Test / Lint
    CI-->>GH: Report status
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I hop through YAML, light and spry,
One step gone—goodbye, goodbye!
Flags now carry what we need,
Sleeker runs with rabbit speed.
CI hums, a tidy tune—
Carrots shipped by afternoon. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix(repo): Remove unused CI step" accurately and concisely describes the removal of the now unused CI block in the repository’s workflow file and clearly reflects the main change in the diff without unnecessary detail or noise.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/remove-commented-out-ci-step

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ce119b2 and d5aba26.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (29)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (tanstack-react-router, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Static analysis
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Analyze (javascript-typescript)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

pkg-pr-new bot commented Sep 27, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6869

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6869

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6869

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6869

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6869

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6869

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6869

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6869

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6869

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6869

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6869

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6869

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6869

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6869

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6869

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6869

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6869

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6869

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6869

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6869

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6869

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6869

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6869

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6869

commit: d5aba26

@jacekradko jacekradko merged commit 28e2ad6 into main Sep 27, 2025
44 checks passed
@jacekradko jacekradko deleted the feat/remove-commented-out-ci-step branch September 27, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants