Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Names should be a field in the recipe #74338

Open
Maleclypse opened this issue Jun 6, 2024 · 1 comment
Open

Conditional Names should be a field in the recipe #74338

Maleclypse opened this issue Jun 6, 2024 · 1 comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@Maleclypse
Copy link
Member

Is your feature request related to a problem? Please describe.

Conditional naming is json line heavy, easily broken by usage of requirement lists, and an excellent candidate for improvement via a small amount of c++

Solution you would like.

I would like to see "conditional_components" as an array based field which accepts requirement lists and item names.
Two methods of definining the conditional name.

  1. apple, 1 This recipe requires a single apple and sets it's conditional name off the singular name of that item. So if you're making cobbler and made it with apples it would be apple cobbler.
  2. triffid_matter, 1, "exo-fruit cobbler". If the player chose to make cobbler with triffid ingredient here you have a defined name.

Describe alternatives you have considered.

This would allow lists to be used in things like icecream and milkshakes without any additional lines for most/all the conditional names. A perfect answer to the commentary in #74269

Additional context

No response

@Maleclypse Maleclypse added <Suggestion / Discussion> Talk it out before implementing [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact labels Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

1 participant