Skip to content

Conversation

JoseKilo
Copy link
Contributor

Close: #25

Skipping the argument parsing completely seems to be enough to solve this issue.

@coveralls
Copy link

coveralls commented Feb 22, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 348dd3f on JoseKilo:fix/25-broken-command-with-arguments into 9565ad7 on click-contrib:master.

@JoseKilo
Copy link
Contributor Author

The errors on Travis seem unrelated to this PR. Probably a caching issue, resetting the cache on Travis should fix it.

pluggy.PluginValidationError: Plugin 'pytest_cov' could not be loaded: (pytest 3.3.0 (/home/travis/virtualenv/python2.7.14/lib/python2.7/site-packages), Requirement.parse('pytest>=3.6'))!

@geowurster
Copy link
Member

@JoseKilo Thanks! This looks good, and I think you are correct about the Travis caching issue, but after attempting to clear the cache and rerun several times the build is still failing with the same error.

Could you push a commit that entirely removes caching from .travis.yml? I just cleared the cache again so hopefully that forces a complete rebuild.

@JoseKilo
Copy link
Contributor Author

JoseKilo commented Mar 1, 2019

I've tried to remove the caching config from .travis.yml completely, but it didn't solve the problem. Bumping the pytest required version to match pytest-cov seems to solve it (pytest>=3.6).
So I've have re-enabled caching after that.

@JoseKilo
Copy link
Contributor Author

Hi @geowurster , do you think we can merge this now ?

@geowurster geowurster merged commit d48fc86 into click-contrib:master Apr 4, 2019
@geowurster
Copy link
Member

geowurster commented Apr 4, 2019

@JoseKilo Done. Released as version 1.1.1.

@JoseKilo
Copy link
Contributor Author

JoseKilo commented Apr 4, 2019

Thanks! 👍

@JoseKilo JoseKilo deleted the fix/25-broken-command-with-arguments branch April 4, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants