Fix/25 broken command with arguments

click_plugins/core.py

@@ -87,3 +87,6 @@ def invoke(self, ctx):
 
         click.echo(self.help, color=ctx.color)
         ctx.exit(1)
+
+    def parse_args(self, ctx, args):
+        return args

setup.py

@@ -51,7 +51,7 @@
                 "via setuptools entry-points.",
     extras_require={
         'dev': [
-            'pytest>=3',
+            'pytest>=3.6',
             'pytest-cov',
             'wheel',
             'coveralls'

tests/test_plugins.py

@@ -78,23 +78,23 @@ def test_registered():
 def test_register_and_run(runner):
 
     result = runner.invoke(good_cli)
-    assert result.exit_code is 0
+    assert result.exit_code == 0
 
     for ep in iter_entry_points('_test_click_plugins.test_plugins'):
         cmd_result = runner.invoke(good_cli, [ep.name, 'something'])
-        assert cmd_result.exit_code is 0
+        assert cmd_result.exit_code == 0
         assert cmd_result.output.strip() == 'passed'
 
 
 def test_broken_register_and_run(runner):
 
     result = runner.invoke(broken_cli)
-    assert result.exit_code is 0
+    assert result.exit_code == 0
     assert u'\U0001F4A9' in result.output or u'\u2020' in result.output
 
     for ep in iter_entry_points('_test_click_plugins.broken_plugins'):
         cmd_result = runner.invoke(broken_cli, [ep.name])
-        assert cmd_result.exit_code is not 0
+        assert cmd_result.exit_code != 0
         assert 'Traceback' in cmd_result.output
 
 
@@ -108,7 +108,7 @@ def sub_cli():
         pass
 
     result = runner.invoke(good_cli)
-    assert result.exit_code is 0
+    assert result.exit_code == 0
     assert sub_cli.name in result.output
     for ep in iter_entry_points('_test_click_plugins.test_plugins'):
         assert ep.name in result.output
@@ -121,13 +121,13 @@ def sub_cli_plugins():
         pass
 
     result = runner.invoke(good_cli, ['sub-cli-plugins'])
-    assert result.exit_code is 0
+    assert result.exit_code == 0
     for ep in iter_entry_points('_test_click_plugins.test_plugins'):
         assert ep.name in result.output
 
     # Execute one of the sub-group's commands
     result = runner.invoke(good_cli, ['sub-cli-plugins', 'cmd1', 'something'])
-    assert result.exit_code is 0
+    assert result.exit_code == 0
     assert result.output.strip() == 'passed'
 
 
@@ -138,3 +138,25 @@ def test_exception():
         @click.command()
         def cli():
             """Whatever"""
+
+
+def test_broken_register_and_run_with_help(runner):
+    result = runner.invoke(broken_cli)
+    assert result.exit_code == 0
+    assert u'\U0001F4A9' in result.output or u'\u2020' in result.output
+
+    for ep in iter_entry_points('_test_click_plugins.broken_plugins'):
+        cmd_result = runner.invoke(broken_cli, [ep.name, "--help"])
+        assert cmd_result.exit_code != 0
+        assert 'Traceback' in cmd_result.output
+
+
+def test_broken_register_and_run_with_args(runner):
+    result = runner.invoke(broken_cli)
+    assert result.exit_code == 0
+    assert u'\U0001F4A9' in result.output or u'\u2020' in result.output
+
+    for ep in iter_entry_points('_test_click_plugins.broken_plugins'):
+        cmd_result = runner.invoke(broken_cli, [ep.name, "-a", "b"])
+        assert cmd_result.exit_code != 0
+        assert 'Traceback' in cmd_result.output