Boot build tool compatibility

[pandeiro]

The cider-jack-in command, hallowed be its name (and shortcut), will unfortunately not boot up a REPL and attach a client to it in projects that use Boot instead of Leiningen. This is unsurprising, given the predominance of lein, but boot support would be nice and, looking into it, the issues at play are simple and mostly confined to nrepl-client.el. Basically, they are:

1. nrepl-project-directory-for needs to recognize build.boot in addition to project.clj files.
2. nrepl-server-filter would need to adjust its regex to accept both lein's "nREPL server started on..." and boot's "nREPL server listening..." outputs

This would enable barebones support, with users using customization to specify "boot" as cider-lein-command and "repl -s wait" as cider-lein-parameters.

However... in the future, perhaps detection by cider for the appropriate defaults for those values on a per-project basis would be convenient to end users.

Question: would a pull request to implement the two immediate simple changes above be welcome? Or, is there any orientation in general on this question?

Thanks

[donmullen]

+1 I think we can do better than this : https://github.com/boot-clj/boot/wiki/Cider-REPL

[bbatsov]

@pandeiro Sure, I'll take a PR implementing this. Adding boot support has been on my roadmap since the Conj.

However... in the future, perhaps detection by cider for the appropriate defaults for those values on a per-project basis would be convenient to end users.

Doing a project type check will be trivial (locate-dominating-file ...). Guess we can add two extra vars - cider-boot-command and cider-boot-parameters for boot projects.

[bbatsov]

+1 I think we can do better than this : https://github.com/boot-clj/boot/wiki/Cider-REPL

@donmullen Lein has special support for nREPL middleware, which makes the setup simpler there. Not sure what we can do about boot. Guess I'll have to play with it (or someone should dig further into this).

[pandeiro]

Cheers @bbatsov, I'll get to this soon but I'd like to be able to pass the tests (#922) first.

[cichli]

Similarly to how cider-nrepl provides a lein plugin to automate adding the dependency and middleware, we could maybe provide a boot task (or even just a fn for users to call in build.boot) that does the same thing?

[bbatsov]

@cichli Yeah, that'd be great.

@pandeiro Any progress with this?

[pandeiro]

@bbatsov I've got a branch with boot support working and the existing tests passing.

I haven't added any tests b/c I couldn't find cider-jack-in specific tests to expand. (TBH I could use some help with that, if you find it necessary.)

My work is here. Let me know if I should submit the PR as-is or if it needs more work, please?

[pandeiro]

@cichli Not sure how that would work, exactly... Would cider, if boot were detected, inject something into build.boot? That seems heavy on the magic to me.

Isn't the recommended method, a $HOME/.profile.boot with the cider-nrepl dependency, akin to $HOME/.lein/profiles.clj, good enough? No?

Or is there another way I'm not seeing?

[pandeiro]

@bbatsov Looking at your line comments now; there is one further issue -- anecdotally it seems some projects have a project.clj and build.boot to facilitate use with either tool. Don't know how prevalent that is/will become, but how would you propose dealing with that? Ie, should cider maybe somehow allow the user to specify the jack-in command to use, as C-u cider-jack-in currently allows the user to select a project? Thoughts?

[bbatsov]

If both files are present we should prompt the user for input.

On Tuesday, January 13, 2015, Murphy McMahon notifications@github.com
wrote:

@bbatsov https://github.com/bbatsov Looking at your line comments now;
there is one further issue -- anecdotally it seems some projects have a
project.clj and build.boot to facilitate use with either tool. Don't know
how prevalent that is/will become, but how would you propose dealing with
that? Ie, should cider maybe somehow allow the user to specify the jack-in
command to use, as C-u cider-jack-in currently allows the user to select a
project? Thoughts?

—
Reply to this email directly or view it on GitHub
#920 (comment).

Best Regards,
Bozhidar Batsov

http://www.batsov.com

[pandeiro]

OK that would be a completing read for 'lein' or 'boot'?

[bbatsov]

Yep.

On Wednesday, January 14, 2015, Murphy McMahon notifications@github.com
wrote:

OK that would be a completing read for 'lein' or 'boot'?

—
Reply to this email directly or view it on GitHub
#920 (comment).

Best Regards,
Bozhidar Batsov

http://www.batsov.com