cider-jump-to-var is broken when there is no symbol at point
#761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vspinu
force-pushed
the
jump-to-var
branch
5 times, most recently
from
8d73eeb to
e7015f5
Compare
Also, make `cider-jump-to-var` and `cider-stacktrace-navigate` use common workhorse.
bbatsov
added a commit
that referenced
this pull request
Sep 1, 2014
`cider-jump-to-var` is broken when there is no symbol at point
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol is taken from
(cider-read-symbol-name "Symbol: " 'identity)which doesn't return anything because it's asynchronous.Also, make
cider-jump-to-varandcider-stacktrace-navigateuse common workhorse as they were using almost identical code.This PR is based on #760 as it touches the same code.