Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape passwords in URLs for dump_config #2753

Merged
merged 4 commits into from
May 5, 2023
Merged

Escape passwords in URLs for dump_config #2753

merged 4 commits into from
May 5, 2023

Conversation

Khrol
Copy link
Contributor

@Khrol Khrol commented Mar 15, 2022 •
edited
Loading

What changes were proposed in this pull request?

  • Hide passwords in connection strings in dump_config

How was this patch tested?

  • Unit test is added (I hope CI runs it)
  • Tested on local env
    image

Please review Hue Contributing Guide before opening a pull request.

@Khrol Khrol marked this pull request as ready for review March 15, 2022 15:05
@bjornalm bjornalm removed the roadmap label Feb 16, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Apr 3, 2023
@Khrol
Copy link
Contributor Author

Khrol commented Apr 3, 2023 •
edited
Loading

I don't see any feedback from maintainers here. 🐼

@github-actions github-actions bot removed the Stale label Apr 4, 2023
@bjornalm
Copy link
Collaborator

bjornalm commented Apr 4, 2023

@Khrol Thanks for contributing. I'm sorry that you haven't received any feedback on this yet, we are working on improving the communication with our community.

@ranade1 Can you have a look at this?

@bjornalm bjornalm requested a review from ranade1 April 4, 2023 10:15
Harshg999
Harshg999 approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @Khrol!

desktop/core/src/desktop/api2_tests.py
@@ -189,6 +189,19 @@ def test_get_hue_config_private(self):
assert_true(len(response.content) < len(private_response.content))


def test_url_password_hiding(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

bjornalm
bjornalm approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @Khrol Thanks again for contributing, it is highly valued :-)

@Harshg999 Harshg999 enabled auto-merge (squash) May 5, 2023 12:11
@Harshg999 Harshg999 merged commit fea91a9 into cloudera:master May 5, 2023
agl29 pushed a commit that referenced this pull request Jul 24, 2023
@Khrol @wing2fly
CDPD-56307: [config] Escape passwords in URLs for dump_config (#2753)
824776a 
(cherry picked from commit fea91a9)
(cherry picked from commit 49efb47)
Change-Id: I64af7f28c135c731267b2a5cfcf184ee55354c89
(cherry picked from commit 1121251)
(cherry picked from commit e0dcee2)
wing2fly pushed a commit that referenced this pull request Mar 6, 2024
@Khrol @wing2fly
CDPD-56307: [config] Escape passwords in URLs for dump_config (#2753)
e0dcee2 
(cherry picked from commit fea91a9)
(cherry picked from commit 49efb47)
Change-Id: I64af7f28c135c731267b2a5cfcf184ee55354c89
(cherry picked from commit 1121251)
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
@Khrol @wing2fly
CDPD-56307: [config] Escape passwords in URLs for dump_config (#2753)
1121251 
(cherry picked from commit fea91a9)
(cherry picked from commit 49efb47)
Change-Id: I64af7f28c135c731267b2a5cfcf184ee55354c89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornalm bjornalm bjornalm approved these changes

@Harshg999 Harshg999 Harshg999 approved these changes

@ranade1 ranade1 Awaiting requested review from ranade1

@wing2fly wing2fly Awaiting requested review from wing2fly

@amitsrivastava amitsrivastava Awaiting requested review from amitsrivastava

@JohanAhlen JohanAhlen Awaiting requested review from JohanAhlen

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

@agl29 agl29 Awaiting requested review from agl29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Khrol @bjornalm @Harshg999 @quadoss