[Backend] Removing future library dependancy as it is not required in… #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranade1
requested review from
Harshg999,
wing2fly,
amitsrivastava,
athithyaaselvam and
agl29
amitsrivastava
approved these changes
May 22, 2023
wing2fly
approved these changes
May 22, 2023
|
We should not see the urllib.parse import error now in CI checks because that was specific to Py2.7 and this PR was a breaking change for it. So, I've removed the Py2 CI as going forward we have remove Py2 stuff anyway. Ref: https://python-future.org/standard_library_imports.html#aliased-imports |
|
Please fix the pylint issues and retrigger the CI checks. |
… Python 3.8 and later. - The future library imports have no effect on Python 3.
|
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Python 3.8 and later.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.