[frontend]Storage Browser initial layout implementation #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornalm
reviewed
Jul 20, 2023
| @@ -17,6 +17,9 @@ export async function loadComponent(name) { | |||
| case 'FileChooserWithButton': | |||
| return (await import('./FileChooser/FileChooserWithButton/FileChooserWithButton')).default; | |||
|
|
|||
| case 'StorageBrowserPage': | |||
There was a problem hiding this comment.
nit: Move up to "Page specific components here" section
| @@ -520,6 +521,9 @@ def listdir_paged(request, path): | |||
| filter=? - Specify a substring filter to search for in | |||
| the filename field. | |||
| """ | |||
| if ENABLE_NEW_STORAGE_BROWSER.get(): | |||
| return render('storage_browser.mako', request, {}) | |||
There was a problem hiding this comment.
Nice, this is needed to get the new react app started, but additional routing within the new storage browser should probably be handed by a browser based router like the react router. Lets discuss once we get there.
JohanAhlen
approved these changes
Jul 31, 2023
| @@ -75,6 +75,14 @@ | |||
| database: string; | |||
| } | |||
|
|
|||
| interface BrowserInterpreter { | |||
There was a problem hiding this comment.
Add to imports above from config/types.ts (if needed)
nidhibhatg
force-pushed
the
nidhi_filebrowser_layout
branch
from
08f9777
to
2bd263a
Compare
tabraiz12
pushed a commit
that referenced
this pull request
Oct 4, 2023
* [frontend]Storage Browser initial layout implementation * [frontend]Fixed python styling * [frontend]Changed feature flag to enable_new_storage_browser * [frontend]Moved models.py changes to UI and improvements * [frontend]Added data-browser icon and improvements (cherry picked from commit 0c47195)
wing2fly
pushed a commit
that referenced
this pull request
Mar 6, 2024
…3397) * [frontend]Storage Browser initial layout implementation * [frontend]Fixed python styling * [frontend]Changed feature flag to enable_new_storage_browser * [frontend]Moved models.py changes to UI and improvements * [frontend]Added data-browser icon and improvements (cherry picked from commit 0c47195) (cherry picked from commit bc07c22) Change-Id: I10899ac6c6d7d92844d400fb3303eb9d9351b6e5 (cherry picked from commit 5afbef3)
athithyaaselvam
pushed a commit
that referenced
this pull request
Mar 14, 2024
…3397) * [frontend]Storage Browser initial layout implementation * [frontend]Fixed python styling * [frontend]Changed feature flag to enable_new_storage_browser * [frontend]Moved models.py changes to UI and improvements * [frontend]Added data-browser icon and improvements (cherry picked from commit 0c47195) (cherry picked from commit bc07c22) Change-Id: I10899ac6c6d7d92844d400fb3303eb9d9351b6e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.