Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result is inconsistent between Hive results On Web and Response Preview #3400

Closed
wants to merge 7 commits into from

Conversation

cgkbfrd
Copy link
Contributor

@cgkbfrd cgkbfrd commented Jul 17, 2023

What changes were proposed in this pull request?

issue #3399

  • if the length of a field in result more than 16, then cast it to string

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
  • (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

@cgkbfrd
Copy link
Contributor Author

cgkbfrd commented Jul 17, 2023

Hello @Harshg999 ,I think the codes I posted is right, but I don't know why the compile is failed,please help me to check.

@Harshg999
Copy link
Collaborator

@cgkbfrd ci/circleci: build-py-38-arm64 is unrelated to your change.

@Harshg999
Copy link
Collaborator

@bjornalm @JohanAhlen @nidhibhatg @agl29 - Is this a JS issue? Can this be fixed from the UI side?

@Harshg999 Harshg999 linked an issue Jul 17, 2023 that may be closed by this pull request
1 task
@bjornalm
Copy link
Collaborator

@Harshg999 First just a note that the bug described in #3399 is from the Editor v2 which still is behind a feature flag. But, there is a real problem when a JSON object from Python API is including integers that could be larger than the maximum safe integer limit of Javascript. Modern JS can handle larger numbers using BigInt but the built in JSON parser doesn't.

So we can either introduce another JSON parser on the client side to handle this properly, or we can solve it by passing larger numbers as strings, like this PR suggets. For simply displaying the data in the result table I think this fix is sufficient but we might also also need to take special care when these numbers are to be used in the charts etc. If this is an external API we should also consider keeping the API consistent and easy to use for other consumers than the Hue UI.

@cgkbfrd cgkbfrd closed this Jul 18, 2023
@cgkbfrd cgkbfrd reopened this Jul 18, 2023
@bjornalm bjornalm requested a review from JohanAhlen July 20, 2023 17:25
@bjornalm
Copy link
Collaborator

@JohanAhlen I think we should be consistent when dealing with this problem and I'm not sure what the strategy has been in the past, but lets discuss when your are back.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Sep 4, 2023
@github-actions github-actions bot closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

result is inconsistent between Hive results On Web and Response Preview
3 participants