Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[importer] Avoid creating scratchdir outside of encryption zone #3447

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

wing2fly
Copy link
Collaborator

What changes were proposed in this pull request?

Issue:
End user is using a csv file in an encryption zone in the importer, then an error pops up:
ValueError: Extra data: line 1 column 5

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
    Added a unit test for checking the scratch path.
    Manual test in a cluster with csv inside/outside encryption zone

Please review Hue Contributing Guide before opening a pull request.

Copy link
Collaborator

@quadoss quadoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Nice unit test!

@wing2fly wing2fly merged commit dccb946 into master Aug 28, 2023
2 checks passed
@wing2fly wing2fly deleted the importer_enc_zone branch August 28, 2023 20:45
tabraiz12 pushed a commit that referenced this pull request Oct 4, 2023
wing2fly added a commit that referenced this pull request Mar 6, 2024
(cherry picked from commit dccb946)
(cherry picked from commit 1da11aa)
Change-Id: I34ca857345ddbeaab7e2bf7c9d421dbebf68277d
(cherry picked from commit b76a1c0)
wing2fly added a commit that referenced this pull request Mar 6, 2024
…ne (#3447)"

This reverts commit 3d38dc8.

Change-Id: Iae508907cc23c6e381d3dfa6929eb877d028fca7
wing2fly added a commit that referenced this pull request Mar 6, 2024
… zone (#3447)

(cherry picked from commit dccb946)
(cherry picked from commit 1da11aa)
(cherry picked from commit b76a1c0)
(cherry picked from commit 3d38dc8)
Change-Id: Iedc2ecb87a20865654f867304d5f4d224e3ff8ac
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
(cherry picked from commit dccb946)
(cherry picked from commit 1da11aa)
Change-Id: I34ca857345ddbeaab7e2bf7c9d421dbebf68277d
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
…ne (#3447)"

This reverts commit b76a1c0. Due to missing Jira ID

Change-Id: Iea90f2edc19995554627804278d106a60782a3d5
athithyaaselvam pushed a commit that referenced this pull request Mar 14, 2024
… zone (#3447)

(cherry picked from commit dccb946)
(cherry picked from commit 1da11aa)
(cherry picked from commit b76a1c0)
Change-Id: I6c6c7e5829d260bad8c90ba6f0c45887a23c3a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants