-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[importer] Avoid creating scratchdir outside of encryption zone #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing2fly
force-pushed
the
importer_enc_zone
branch
from
August 26, 2023 04:43
3be74c4
to
2521dca
Compare
quadoss
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Harshg999
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice unit test!
tabraiz12
pushed a commit
that referenced
this pull request
Oct 4, 2023
(cherry picked from commit dccb946)
wing2fly
added a commit
that referenced
this pull request
Mar 6, 2024
wing2fly
added a commit
that referenced
this pull request
Mar 6, 2024
athithyaaselvam
pushed a commit
that referenced
this pull request
Mar 14, 2024
athithyaaselvam
pushed a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Issue:
End user is using a csv file in an encryption zone in the importer, then an error pops up:
ValueError: Extra data: line 1 column 5
How was this patch tested?
Added a unit test for checking the scratch path.
Manual test in a cluster with csv inside/outside encryption zone
Please review Hue Contributing Guide before opening a pull request.