Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci]Change node version from 14 to 18 in Frontend CI #3495

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

nidhibhatg
Copy link
Collaborator

What changes were proposed in this pull request?

  • Changed node version from 14 to 18 in Frontend CI

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
  • (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

@Harshg999
Copy link
Collaborator

Harshg999 commented Oct 9, 2023

Surprisingly this did not trigger the Frontend CI checks.
@nidhibhatg - Can you also add this file in the allowed list?

Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nidhibhatg nidhibhatg merged commit 09db3e7 into master Oct 9, 2023
4 of 5 checks passed
@nidhibhatg nidhibhatg deleted the nidhi_node_ci branch October 9, 2023 13:30
athithyaaselvam pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants