Added option to add phone number to create and update user #753
Conversation
|
Hey gkhunger! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
|
@gkhunger Let me know when you've signed the CLA so that we can get this merged in quickly. |
|
Do I need to be a cloud foundry member to sign it? |
|
@gkhunger You do not. You can just follow the links there and the instructions will guide you along. |
|
Somehow the link takes me to https://www.cloudfoundry.org/governance/ |
|
@chipchilders It appears that something has broken the CLA links on Cloud Foundry website. Tapping the Individual CLA link results in a loop back to the main governance page. Can you please have someone look into that? |
|
Yes - getting our web team to look right now. |
| abstract Boolean getVerified(); | ||
|
|
||
| /** | ||
| * The phone number |
| import org.immutables.value.Value; | ||
|
|
||
| /** | ||
| * The email addresses for a user |
There was a problem hiding this comment.
Copy/paste error (my speciality!)
| * The phone numbers for the user | ||
| */ | ||
| @JsonProperty("phoneNumbers") | ||
| abstract List<PhoneNumber> getPhoneNumbers(); |
There was a problem hiding this comment.
Fields should be in alphabetical order (alt-cmd-L will fix that)
| * The phone numbers for the user | ||
| */ | ||
| @JsonProperty("phoneNumbers") | ||
| public abstract List<PhoneNumber> getPhoneNumbers(); |
There was a problem hiding this comment.
Fields should be in alphabetical order
This commit adds support for phone numbers when creating and updating a user in uaa. [resolves #753]
Previously the create and update user requests did not have properties for specifying phone numbers. This addition of phone number is a recent addition to the UAA API and needed to be added. This change adds phone numbers to those requests. [#753]
|
@chipchilders Looks good from my side. |
|
Works for me too. Thanks. |
|
I received an email from Chris Clark that he received my CLA. Can we merge the code now? |
|
Let's find out... |
|
Hey gkhunger! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
Looks good. |
Previously the create and update user requests did not have properties for specifying phone numbers. This addition of phone number is a recent addition to the UAA API and needed to be added. This change adds phone numbers to those requests. [#753]
5 participants
In our project we needed to use a user's phone number information.