Skip to content

Conversation

arghya88
Copy link
Contributor

closes #889

@cfdreddbot
Copy link

Hey arghya88!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@twoseat twoseat closed this in b115e02 May 22, 2018
@twoseat twoseat added this to the 2.29.0.RELEASE milestone May 22, 2018
@twoseat twoseat self-assigned this May 22, 2018
@twoseat twoseat added the client label May 22, 2018
@twoseat
Copy link
Contributor

twoseat commented May 22, 2018

Thanks @arghya88 - note the pluralisation of parameters, and the error in the integration test (though I understand that's hard to check without a test environment!)

@arghya88
Copy link
Contributor Author

@twoseat I looked at the integration test...what error you got and why you had to do this change if you can explain ?..I have a cf but I am not sure how/if I can run only this test.Tried running the whole set of integration tests but some other test related to buildpack keeps failing..

@arghya88
Copy link
Contributor Author

@twoseat Noted on this...Can you explain what failed and why the reordering the tests were necessary?

I just tried running this test and it fails with below error on my cf instance:

Found unexpected property stack in payload for org.cloudfoundry.client.v2.buildpacks.BuildpackEntity$Json

Any idea?

@twoseat
Copy link
Contributor

twoseat commented May 22, 2018

Hi @arghya88!

The organisation test failed because it was trying to filter on .space() (fe555ec#diff-52c358d0d9df26bdda7d2892da39173dR135).

The reordering of tests isn't strictly necessary, but we try to keep everything in alphabetical order (there are exceptions, but not many!). Fortunately hitting alt-cmd-L inside a class in Intellij generally takes care of such things.

The error you're seeing typically means that CF has returned a field that we don't know about. A quick check of the docs suggests that stack isn't something we should be expecting, so not sure what's happening...

@arghya88
Copy link
Contributor Author

Got it...doing cf curl v2/buildpacks gives me a json which has stacks in it..api version is 2.111.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional filters for /v2/events
3 participants