Support independent pip version #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menehune23
commented
Oct 13, 2021
menehune23
force-pushed
the
172-independent-pip
branch
from
da54381 to
075863c
Compare
menehune23
commented
Oct 13, 2021
| return err | ||
| } | ||
|
|
||
| if err := s.Command.Execute(s.Stager.BuildDir(), indentWriter(os.Stdout), indentWriter(os.Stderr), |
Contributor
Author
There was a problem hiding this comment.
Note that we don't use Supplier.runPipInstall() here because we need to ensure that python's own pip module is used. Supplier.runPipInstall() would try to use the very version of pip we're installing here.
menehune23
force-pushed
the
172-independent-pip
branch
from
075863c to
402a2fc
Compare
Adds pip as a dependency to this buildpack. When BP_PIP_VERSION=latest, this version will be used. When unset, python's own pip module will be used.
menehune23
force-pushed
the
172-independent-pip
branch
from
402a2fc to
1c32c4d
Compare
Member
|
LGTM |
This was referenced Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for installing a version of pip that is independent of python, to be used for this buildpack's build logic. This PR adds only a single pip version to the manifest, which is selectable by setting
$BP_PIP_VERSION=latest(env var named as such for easier potential extensibility -- e.g. adding more versions of pip to the manifest, selectable by version number). If this env var is empty/unset, nothing will be installed and python's own pip module will be used for the build.Resolves #172
Resolves #171 (since the added version of pip contains
wheelandsetuptools)developbranch