Use aria-labelledby to add accessible names to articles #1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce199d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for cloudfour-patterns ready! 🔨 Explore the source changes: ce199d0 🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/613a5e5c4259af000784a178 😎 Browse the preview: https://deploy-preview-1530--cloudfour-patterns.netlify.app |
Merged
gerardo-rodriguez
added a commit
that referenced
this pull request
Sep 13, 2021
…into feature/button-swap * 'v-next' of github.com:cloudfour/cloudfour.com-patterns: Update storybook monorepo to v6.3.8 Update babel monorepo Incease whitespace for the ground nav component (#1533) Responsive fallback (#1529) Use aria-labelledby to add accessible names to articles (#1530) # Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Recently @gerardo-rodriguez pointed out:
This PR adds
aria-labelledbyto link the existing comment headings to the comment article.You're gonna wanna hide whitespace changes while reviewing. There was an indentation issue in the file that was fixed as well.
Screenshots
Testing
/?path=/story/components-comment--with-reply-threadon the preview deploy in VoiceOver. Check the rotor and note the articles have accessible names.