Skip to content

Use aria-labelledby to add accessible names to articles #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Use aria-labelledby to add accessible names to articles #1530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rude-pears-breathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cloudfour/patterns': patch
---

Add accessible names to comments
29 changes: 15 additions & 14 deletions src/components/comment/comment.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,23 @@
<article
class="c-comment {{_comment_modifiers}}"
id="comment-{{comment.ID}}"
aria-labelledby="comment-heading-{{comment.ID}}"
>
<header class="c-comment__header">
{% block header_content %}
<h{{_heading_depth}} class="c-comment__heading">
{% block heading_content %}
{% block author_title %}
{{comment.author.name}}
{% endblock %}
<header class="c-comment__header">
{% block header_content %}
<h{{_heading_depth}} class="c-comment__heading" id="comment-heading-{{comment.ID}}">
{% block heading_content %}
{% block author_title %}
{{comment.author.name}}
{% endblock %}

<span class="u-hidden-visually">
{% if comment.is_child %}replied{% else %}said{% endif %}:
</span>
{% endblock %}
</h{{_heading_depth}}>
{% endblock %}
</header>
<span class="u-hidden-visually">
{% if comment.is_child %}replied{% else %}said{% endif %}:
</span>
{% endblock %}
</h{{_heading_depth}}>
{% endblock %}
</header>
<div class="c-comment__object">
{% include '@cloudfour/components/avatar/avatar.twig' with {
src: comment.avatar,
Expand Down