-
Notifications
You must be signed in to change notification settings - Fork 3
Use logical properties consistently #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f93f46a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for cloudfour-patterns ready! 🔨 Explore the source changes: f93f46a 🔍 Inspect the deploy log: https://app.netlify.com/sites/cloudfour-patterns/deploys/619c221efd33b40007ae0ea6 😎 Browse the preview: https://deploy-preview-1595--cloudfour-patterns.netlify.app |
Code looks good! Just finished testing for regressions in Edge. I'll test Safari next. I should note that I'm not super familiar with these patterns, so while I don't see any obvious problems, it might be worth tapping Danielle or another designer to do a regression pass as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safari looks good too.
I noticed two unrelated bugs in Safari (that are also visible in v-next):
-
Large amount of white space below Overview blocks (visible on the Overview page and the Article Listing prototype). (#1596)
-
Hovering an avatar on the Team List page turns the avatar square, in a weird flickering way that looks broken. (#1597)
I'll file bugs for those.
I'm going to approve this PR, but I'd still appreciate a designer who's more familiar with these patterns doing a quick regression sweep.
I tested in Chrome since it looks like the other browsers have been covered. I didn't find any regressions, going to approve from a design standpoint. |
Overview
This PR installs a plugin for linting logical properties and applies those fixes across all existing stylesheets.
Please note that the intent of this PR is to enforce consistent property usage, not to optimize each and every component for different text directions and writing modes.
Screenshots
Testing