Skip to content

Use logical properties consistently #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2021
Merged

Use logical properties consistently #1595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab1b399
Add stylelint-use-logical-spec
tylersticka Nov 22, 2021
97c93d9
Logical properties lint changes
tylersticka Nov 22, 2021
e11e903
Remove lingering comment
tylersticka Nov 22, 2021
f93f46a
Add changeset
tylersticka Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-pets-yell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cloudfour/patterns': minor
---

Use logical properties across existing styles to improve future-friendliness of patterns.
8 changes: 8 additions & 0 deletions .stylelintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
module.exports = {
plugins: ['stylelint-use-logical-spec'],
extends: ['stylelint-config-cloudfour', 'stylelint-config-prettier'],
rules: {
// disable stylelint-scss rules that conflict with prettier
Expand Down Expand Up @@ -38,5 +39,12 @@ module.exports = {
'suitcss/custom-property-no-outside-root': null,
// we want to be able to compose :root for theme selectors (#1056)
'suitcss/selector-root-no-composition': null,
'liberty/use-logical-spec': [
'always',
{
// Until Safari 15 adoption is higher
except: ['clear', 'float', /^border-.+-radius$/i],
},
],
},
};
Loading