Skip to content

Conversation

gerardo-rodriguez
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez commented Jul 26, 2022

Overview

This PR conditionally adds aria-hidden="true" for when an ellipsis is rendered in the Pagination component.

Screenshots

Screen Shot 2022-07-27 at 11 38 13 AM

Testing

The best test method will be using your local Cloud Four WordPress site. We can use npm link to link to this patterns version.

Checkout both repos

  1. Checkout out the cloudfour.com-wp main branch locally
  2. Checkout this cloudfour.com-patterns branch locally

In the cloudfour.com-patterns repo

  1. npm ci && npm run build && npm link

In the cloudfour.com-wp repo

  1. In the theme directory: npm ci && npm link @cloudfour/patterns && npm run build

Confirm

  • On the /thinks, the Pagination component ellipsis should have aria-hidden"true"

Undo npm link

  1. In the WP repo: npm uninstall --no-save @cloudfour/patterns && npm i
  2. In the Patterns repo (delete global symlink): npm uninstall

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

🦋 Changeset detected

Latest commit: 2fb1a44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 26, 2022

Deploy Preview for cloudfour-patterns ready!

Name Link
🔨 Latest commit 2fb1a44
🔍 Latest deploy log https://app.netlify.com/sites/cloudfour-patterns/deploys/62e186a8bbc88700083c42ec
😎 Deploy Preview https://deploy-preview-1983--cloudfour-patterns.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gerardo-rodriguez gerardo-rodriguez self-assigned this Jul 26, 2022
@gerardo-rodriguez gerardo-rodriguez marked this pull request as ready for review July 26, 2022 23:51
@gerardo-rodriguez
Copy link
Member Author

@tylersticka Ready for another review, thanks for your feedback! 🎉

@gerardo-rodriguez gerardo-rodriguez merged commit e5af776 into main Jul 27, 2022
@gerardo-rodriguez gerardo-rodriguez deleted the fix/hide-pagination-ellipsis branch July 27, 2022 21:43
@github-actions github-actions bot mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ARIA to hide ellipsis in Pagination component?
2 participants