Use aria-hidden for Pagination component ellipsis #1983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR conditionally adds
aria-hidden="true"
for when an ellipsis is rendered in the Pagination component.Screenshots
Testing
The best test method will be using your local Cloud Four WordPress site. We can use
npm link
to link to this patterns version.Checkout both repos
cloudfour.com-wp
main
branch locallycloudfour.com-patterns
branch locallyIn the
cloudfour.com-patterns
reponpm ci && npm run build && npm link
In the
cloudfour.com-wp
reponpm ci && npm link @cloudfour/patterns && npm run build
Confirm
/thinks
, the Pagination component ellipsis should havearia-hidden"true"
Undo
npm link
npm uninstall --no-save @cloudfour/patterns && npm i
npm uninstall