Skip to content

Use aria-hidden for Pagination component ellipsis #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Use aria-hidden for Pagination component ellipsis #1983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aabb78a
Use aria-hidden for Pagination component ellipsis
gerardo-rodriguez Jul 26, 2022
79fdd27
Add changeset
gerardo-rodriguez Jul 26, 2022
6eafa6b
Move aria-hidden to li
gerardo-rodriguez Jul 26, 2022
2fb1a44
PR feedback, repeat li
gerardo-rodriguez Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-owls-pay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cloudfour/patterns': minor
---

Add aria-hidden to Pagination component ellipsis
31 changes: 22 additions & 9 deletions src/components/pagination/pagination.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,34 +5,47 @@
<{{ label_tag_name }} id="{{ label_id }}" class="u-hidden-visually">Pagination</{{ label_tag_name }}>
<ul class="c-pagination__items" role="list">
{% for page in pagination.pages %}
<li class="c-pagination__item">
{% if page.current %}
{% if page.current %}
<li class="c-pagination__item">
<a class="c-pagination__action" href="{{ page.link }}" aria-current="page">
<span class="u-hidden-visually">Page</span>
<span class="c-pagination__number">{{ page.title }}</span>
</a>
{% elseif page.link and page.link == pagination.prev.link %}
</li>
{% elseif page.link and page.link == pagination.prev.link %}
<li class="c-pagination__item">
<a class="c-pagination__action is-previous" href="{{ page.link }}">
<span class="u-hidden-visually">Previous: Page</span>
<span class="c-pagination__number">{{ page.title }}</span>
</a>
{% elseif page.link and page.link == pagination.next.link %}
</li>
{% elseif page.link and page.link == pagination.next.link %}
<li class="c-pagination__item">
<a class="c-pagination__action is-next" href="{{ page.link }}">
<span class="u-hidden-visually">Next: Page</span>
<span class="c-pagination__number">{{ page.title }}</span>
</a>
{% elseif page.link %}
</li>
{% elseif page.link %}
<li class="c-pagination__item">
<a class="c-pagination__action" href="{{ page.link }}">
<span class="u-hidden-visually">Page</span>
<span class="c-pagination__number">{{ page.title }}</span>
</a>
{% else %}
{# Fallback for non-link pages like ellipsis gaps for first/last pages #}
</li>
{% else %}
{# Fallback for non-link pages like ellipsis gaps for first/last pages #}
<li
class="c-pagination__item"
{% if page.title == '&hellip;' or page.title == '…' %}
aria-hidden="true"
{% endif %}
>
<span class="c-pagination__action">
{{ page.title }}
</span>
{% endif %}
</li>
</li>
{% endif %}
{% endfor %}
</ul>
</nav>