Skip to content

Add variable fonts #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2020
Merged

Add variable fonts #506

merged 6 commits into from
Mar 4, 2020

Conversation

calebeby
Copy link
Member

@calebeby calebeby commented Feb 27, 2020 •
edited
Loading

Closes #469

https://deploy-preview-506--cloudfour-patterns.netlify.com/?path=/story/demo-button--button-element

Testing

  • Apply different font weights and styles to the button using devtools to verify that the Source Sans Pro variable font is working correctly
  • Change the button to use "Source Code Pro" and verify that it works (this is not a variable font)

Test in IE11 to see if the Source Sans Pro non-variable font fallbacks are loaded

@Paul-Hebert
Copy link
Contributor

I know this is WIP but it's exciting!

@calebeby calebeby marked this pull request as ready for review March 3, 2020 19:15
@calebeby calebeby requested a review from tylersticka March 3, 2020 19:16
@calebeby calebeby changed the title [WIP] Add variable fonts Add variable fonts Mar 3, 2020
@calebeby calebeby requested review from a team March 3, 2020 19:17
@calebeby calebeby linked an issue Mar 3, 2020 that may be closed by this pull request
Variable font assets #469
Closed
19 tasks
tylersticka
tylersticka reviewed Mar 3, 2020
View reviewed changes
@tylersticka
Copy link
Member

variable-whee

This is so much fun!

@calebeby
Copy link
Member Author

calebeby commented Mar 3, 2020

variable-whee

This is so much fun!

That is so cool! I didn't know firefox had a slider for that

@calebeby calebeby requested a review from tylersticka March 4, 2020 00:37
tylersticka
tylersticka reviewed Mar 4, 2020
View reviewed changes
@calebeby calebeby merged commit 702ab85 into v-next Mar 4, 2020
@calebeby calebeby deleted the feature/variable-fonts branch March 4, 2020 00:51
@tylersticka tylersticka mentioned this pull request Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersticka tylersticka tylersticka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable font assets
3 participants
@calebeby @Paul-Hebert @tylersticka